feat(ast/estree): add phase field to ImportDeclaration in ESTree AST#11157
Merged
graphite-app[bot] merged 1 commit intomainfrom May 19, 2025
Conversation
github-actions
bot
added
A-ast
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #11157 will degrade performances by 11.86%Comparing Summary
Benchmarks breakdown
|
Member
Merge activity
|
overlookmotel
changed the base branch from
05-19-docs_napi_update_docs_for_oxc-parser_
to
graphite-base/11157
overlookmotel
force-pushed
the
graphite-base/11157
branch
from
afa2f60 to
9be80ed
Compare
overlookmotel
force-pushed
the
05-19-feat_ast_estree_add_phase_field_to_importdeclaration_in_estree_ast
branch
from
d3bd0a8 to
c585a25
Compare
overlookmotel
changed the base branch from
graphite-base/11157
to
05-19-refactor_ast_remove_dummy_comment
graphite-app
bot
force-pushed
the
05-19-refactor_ast_remove_dummy_comment
branch
from
9be80ed to
e92bf1f
Compare
overlookmotel
changed the base branch from
05-19-refactor_ast_remove_dummy_comment
to
graphite-base/11157
overlookmotel
force-pushed
the
05-19-feat_ast_estree_add_phase_field_to_importdeclaration_in_estree_ast
branch
from
c585a25 to
5ef3893
Compare
…AST (#11157) Fixes #10978. Add `phase` property to `ImportDeclaration` in ESTree and TS-ESTree ASTs. `ImportExpression` is not covered by this PR. That's more tricky as TS-ESLint already supports `import.defer(...)` and `import.source(...)`, but does not align with ESTree - it outputs a `MetaProperty` instead. `acorn-test262` submodule is bumped to include oxc-project/estree-conformance#30.
graphite-app
bot
force-pushed
the
05-19-feat_ast_estree_add_phase_field_to_importdeclaration_in_estree_ast
branch
from
5ef3893 to
1bc8d29
Compare
graphite-app
bot
deleted the
05-19-feat_ast_estree_add_phase_field_to_importdeclaration_in_estree_ast
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10978. Add
phaseproperty toImportDeclarationin ESTree and TS-ESTree ASTs.ImportExpressionis not covered by this PR. That's more tricky as TS-ESLint already supportsimport.defer(...)andimport.source(...), but does not align with ESTree - it outputs aMetaPropertyinstead.acorn-test262submodule is bumped to include oxc-project/estree-conformance#30.