feat: add phase field to ImportDeclaration#30
Merged
overlookmotel merged 2 commits intomainfrom May 19, 2025
Merged
Conversation
overlookmotel
deleted the
05-19-feat_add_phase_field_to_importdeclaration_
branch
graphite-app bot
pushed a commit
to oxc-project/oxc
that referenced
this pull request
May 19, 2025
…AST (#11157) Fixes #10978. Add `phase` property to `ImportDeclaration` in ESTree and TS-ESTree ASTs. `ImportExpression` is not covered by this PR. That's more tricky as TS-ESLint already supports `import.defer(...)` and `import.source(...)`, but does not align with ESTree - it outputs a `MetaProperty` instead. `acorn-test262` submodule is bumped to include oxc-project/estree-conformance#30.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a field
phasetoImportDeclarationto support oxc-project/oxc#10978.This field is always
nullbecause neither Acorn or TS-ESLint parser supports this syntax.