feat(ast_tools): introduce #[js_only] attr for struct fields and converters#11160
Merged
graphite-app[bot] merged 1 commit intomainfrom May 19, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #11160 will not alter performanceComparing Summary
Benchmarks breakdown
|
d3bd0a8 to
c585a25
Compare
f11616b to
c7efda2
Compare
Member
Merge activity
|
c585a25 to
5ef3893
Compare
c7efda2 to
e45841a
Compare
…nverters (#11160) Codegen for `ESTree` impls supports a `#[ts]` attribute on struct fields which only appear in TS-ESTree AST. Add a `#[js_only]` attribute which does the same thing in reverse - indicates a field only appears in the JS ESTree AST, and not in TS-ESTree. This allows removing a custom serializer and hacky workaround for `JSXOpeningFragment`.
5ef3893 to
1bc8d29
Compare
e45841a to
9e90e00
Compare
Base automatically changed from
05-19-feat_ast_estree_add_phase_field_to_importdeclaration_in_estree_ast
to
main
May 19, 2025 15:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Codegen for
ESTreeimpls supports a#[ts]attribute on struct fields which only appear in TS-ESTree AST. Add a#[js_only]attribute which does the same thing in reverse - indicates a field only appears in the JS ESTree AST, and not in TS-ESTree.This allows removing a custom serializer and hacky workaround for
JSXOpeningFragment.