feat(ast/estree): add phase field to ImportExpression in ESTree AST#11165
Merged
graphite-app[bot] merged 1 commit intomainfrom May 20, 2025
Conversation
This was referenced May 19, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-ast
CodSpeed Instrumentation Performance ReportMerging #11165 will degrade performances by 12.59%Comparing Summary
Benchmarks breakdown
|
graphite-app
bot
changed the base branch from
05-19-feat_ast_tools_introduce_js_only_attr_for_struct_fields_and_converters
to
graphite-base/11165
graphite-app
bot
force-pushed
the
graphite-base/11165
branch
from
e45841a to
9e90e00
Compare
graphite-app
bot
force-pushed
the
05-19-feat_ast_estree_add_phase_field_to_importexpression_in_estree_ast
branch
from
883d726 to
2273734
Compare
graphite-app
bot
force-pushed
the
05-19-feat_ast_estree_add_phase_field_to_importexpression_in_estree_ast
branch
from
2273734 to
764ad7f
Compare
Boshen
force-pushed
the
05-19-feat_ast_estree_add_phase_field_to_importexpression_in_estree_ast
branch
from
764ad7f to
6ce32bb
Compare
Member
Merge activity
|
…ST (#11165) Related to #10978. Add `phase` property to `ImportExpression` in ESTree AST. This property is *not* added in TS-ESTree, because TS-ESLint supports `import.defer(...)` and `import.source(...)`, but does not align with ESTree - it outputs a `CallExpression` with a `MetaProperty` as its `callee` instead. We don't have the necessary information in our AST to match TS-ESLint, because we don't have the spans of `import`, `defer`, or `import.defer`, to use for the `MetaProperty`, or the `IdentifierName`s it contains. Presumably TS-ESLint will change their AST shape to conform to ESTree spec once these reach stage 4, so I don't think we should expend and changing our AST to align with them in the meantime. TypeScript doesn't even have test cases for these (we'd know if they did, as we'd be failing them) - so I doubt these are popular constructs in TS. `acorn-test262` submodule is bumped to include oxc-project/estree-conformance#31.
graphite-app
bot
force-pushed
the
05-19-feat_ast_estree_add_phase_field_to_importexpression_in_estree_ast
branch
from
6ce32bb to
d47b305
Compare
graphite-app
bot
deleted the
05-19-feat_ast_estree_add_phase_field_to_importexpression_in_estree_ast
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #10978. Add
phaseproperty toImportExpressionin ESTree AST.This property is not added in TS-ESTree, because TS-ESLint supports
import.defer(...)andimport.source(...), but does not align with ESTree - it outputs aCallExpressionwith aMetaPropertyas itscalleeinstead.We don't have the necessary information in our AST to match TS-ESLint, because we don't have the spans of
import,defer, orimport.defer, to use for theMetaProperty, or theIdentifierNames it contains.Presumably TS-ESLint will change their AST shape to conform to ESTree spec once these reach stage 4, so I don't think we should expend and changing our AST to align with them in the meantime. TypeScript doesn't even have test cases for these (we'd know if they did, as we'd be failing them) - so I doubt these are popular constructs in TS.
acorn-test262submodule is bumped to include oxc-project/estree-conformance#31.