Skip to content

refactor(ast): remove dummy comment#11161

Closed
overlookmotel wants to merge 0 commit intomainfrom
05-19-refactor_ast_remove_dummy_comment
Closed

refactor(ast): remove dummy comment#11161
overlookmotel wants to merge 0 commit intomainfrom
05-19-refactor_ast_remove_dummy_comment

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 19, 2025

Remove dummy comment I had to add to #11156 to get CI to run, to allow merging.

@github-actions github-actions bot added A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels May 19, 2025
Copy link
Member Author

overlookmotel commented May 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review May 19, 2025 14:10
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label May 19, 2025
Copy link
Member Author

overlookmotel commented May 19, 2025

Merge activity

  • May 19, 10:11 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • May 19, 10:16 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • May 19, 2:24 PM UTC: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason.

@codspeed-hq
Copy link

codspeed-hq bot commented May 19, 2025

CodSpeed Instrumentation Performance Report

Merging #11161 will degrade performances by 10.62%

Comparing 05-19-refactor_ast_remove_dummy_comment (9be80ed) with 05-19-docs_napi_update_docs_for_oxc-parser_ (73f1bc2)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 2.7 ms 3.1 ms -10.62%

@graphite-app graphite-app bot changed the base branch from 05-19-docs_napi_update_docs_for_oxc-parser_ to graphite-base/11161 May 19, 2025 14:15
@graphite-app graphite-app bot changed the base branch from graphite-base/11161 to main May 19, 2025 14:22
@graphite-app graphite-app bot closed this May 19, 2025
@graphite-app graphite-app bot force-pushed the 05-19-refactor_ast_remove_dummy_comment branch from 9be80ed to e92bf1f Compare May 19, 2025 14:23
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 19, 2025
@overlookmotel
Copy link
Member Author

Why did you close this Graphite, you joker?

@Boshen Boshen deleted the 05-19-refactor_ast_remove_dummy_comment branch August 30, 2025 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant