Skip to content

docs(napi): update docs for oxc-parser#11156

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-19-docs_napi_update_docs_for_oxc-parser_
May 19, 2025
Merged

docs(napi): update docs for oxc-parser#11156
graphite-app[bot] merged 1 commit intomainfrom
05-19-docs_napi_update_docs_for_oxc-parser_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 19, 2025

Update docs for oxc-parser NPM package to clarify:

  1. TS AST now aligns with TS-ESLint.
  2. We align with Acorn for plain JS ESTree.
  3. We add a non-standard hashbang property to Program.

Copy link
Member Author

overlookmotel commented May 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-docs Category - Documentation. Related to user-facing or internal documentation label May 19, 2025
@overlookmotel overlookmotel marked this pull request as ready for review May 19, 2025 12:35
@codspeed-hq
Copy link

codspeed-hq bot commented May 19, 2025

CodSpeed Instrumentation Performance Report

Merging #11156 will degrade performances by 12.54%

Comparing 05-19-docs_napi_update_docs_for_oxc-parser_ (e92bf1f) with main (1a4fec0)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3 ms 3.5 ms -12.54%

Update docs for `oxc-parser` NPM package to clarify:

1. TS AST now aligns with TS-ESLint.
2. We align with Acorn for plain JS ESTree.
3. We add a non-standard `hashbang` property to `Program`.
@graphite-app graphite-app bot force-pushed the 05-19-docs_napi_update_docs_for_oxc-parser_ branch from 73f1bc2 to e92bf1f Compare May 19, 2025 14:15
@graphite-app
Copy link
Contributor

graphite-app bot commented May 19, 2025

Merge activity

@graphite-app graphite-app bot merged commit e92bf1f into main May 19, 2025
23 checks passed
@graphite-app graphite-app bot deleted the 05-19-docs_napi_update_docs_for_oxc-parser_ branch May 19, 2025 14:21
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 19, 2025
@overlookmotel
Copy link
Member Author

mangler[cal.com.tsx] 3.5 ms 2.7 ms +27.46%

Woo hoo! Who'd have thought just updating documentation could have such dramatic effects on performance?!

@overlookmotel
Copy link
Member Author

mangler[cal.com.tsx] 3 ms 3.5 ms -12.54%

Oh no, it's changed! We must revert this PR.

graphite-app bot pushed a commit that referenced this pull request May 19, 2025
Remove dummy comment I had to add to #11156 to get CI to run, to allow merging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant