Skip to content

Conversation

@mtulio
Copy link
Contributor

@mtulio mtulio commented May 7, 2025

Add skip to prevent permanent job failures caused by permanent test failures fixed in o/k repo.

The final solution are coordinated with several changes in the test framework, which depends on:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 7, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 7, 2025

@mtulio: This pull request references SPLAT-2192 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Add skip to prevent permanent job failures caused by permanent test failures fixed in o/k repo.

The final solution are coordinated with several changes in the test framework, which depends on:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

…m fixes

Add skip to prevent permanent job failures caused by permanent test failures fixed in o/k repo.

The final solution are coordinated with several changes in the test framework, which depends on:

- https://issues.redhat.com/browse/SPLAT-2190: introduce external provider to the test framework 4.17-
- https://issues.redhat.com/browse/SPLAT-2191: update e2e step to set the provider across all jobs
    - openshift#64359 : once merged, fixes 4.18+, but 4.17- depends on SPLAT-2190
- [remove test skips for fixed permanent failures](https://issues.redhat.com/browse/SPLAT-2192)
@mtulio mtulio force-pushed the SPLAT-2192-e2e-external-aws-tmp-skip branch from 46059fd to 79fe9ce Compare May 7, 2025 19:04
@openshift-ci openshift-ci bot requested review from elmiko and rvanderp3 May 7, 2025 19:05
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mtulio: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-main-e2e-external-aws openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-main-e2e-external-aws-ccm openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.20-e2e-external-aws openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.20-e2e-external-aws-ccm openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.19-e2e-external-aws openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.19-e2e-external-aws-ccm openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.18-e2e-external-aws openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.18-e2e-external-aws-ccm openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.17-e2e-external-aws openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.17-e2e-external-aws-ccm openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.16-e2e-external-aws-ccm openshift/installer presubmit Registry content changed
pull-ci-openshift-origin-main-e2e-external-aws openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-main-e2e-external-aws-ccm openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.20-e2e-external-aws openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.20-e2e-external-aws-ccm openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.19-e2e-external-aws openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.19-e2e-external-aws-ccm openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.18-e2e-external-aws openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.18-e2e-external-aws-ccm openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.17-e2e-external-aws openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.17-e2e-external-aws-ccm openshift/origin presubmit Registry content changed
pull-ci-openshift-kubernetes-master-e2e-external-aws-ccm openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.20-e2e-external-aws-ccm openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.19-e2e-external-aws-ccm openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.18-e2e-external-aws-ccm openshift/kubernetes presubmit Registry content changed

A total of 37 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mtulio: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kubernetes-master-e2e-external-aws-ccm openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.20-e2e-external-aws-ccm openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.19-e2e-external-aws-ccm openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.18-e2e-external-aws-ccm openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-origin-main-e2e-external-aws openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-main-e2e-external-aws-ccm openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.20-e2e-external-aws openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.20-e2e-external-aws-ccm openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.19-e2e-external-aws openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.19-e2e-external-aws-ccm openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.18-e2e-external-aws openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.18-e2e-external-aws-ccm openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.17-e2e-external-aws openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.17-e2e-external-aws-ccm openshift/origin presubmit Registry content changed
pull-ci-openshift-installer-main-e2e-external-aws openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-main-e2e-external-aws-ccm openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.20-e2e-external-aws openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.20-e2e-external-aws-ccm openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.19-e2e-external-aws openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.19-e2e-external-aws-ccm openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.18-e2e-external-aws openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.18-e2e-external-aws-ccm openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.17-e2e-external-aws openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.17-e2e-external-aws-ccm openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-release-4.16-e2e-external-aws-ccm openshift/installer presubmit Registry content changed

A total of 37 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mtulio
Copy link
Contributor Author

mtulio commented May 7, 2025

Holding until following rehearsal to pass (current one is failing caused by permanent test failures)
/pj-rehearse periodic-ci-openshift-release-master-nightly-4.19-e2e-external-aws
/hold

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2025
@mtulio
Copy link
Contributor Author

mtulio commented May 8, 2025

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.19-e2e-external-aws periodic-ci-openshift-release-master-nightly-4.18-e2e-external-aws

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio
Copy link
Contributor Author

mtulio commented May 8, 2025

4.19 payload is failing in recent releases, 4.18 ACK.

I am ok to merge this as we already tested enough that flag in o/k and origin projects, and now we are blind in periodic due permanent failures.

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.17-e2e-external-aws

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, mtulio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 8, 2025

@mtulio: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.19-e2e-external-aws 79fe9ce link unknown /pj-rehearse periodic-ci-openshift-release-master-nightly-4.19-e2e-external-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mtulio
Copy link
Contributor Author

mtulio commented May 9, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2025
@mtulio
Copy link
Contributor Author

mtulio commented May 9, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 9, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit ec44564 into openshift:master May 9, 2025
12 of 13 checks passed
@mtulio mtulio deleted the SPLAT-2192-e2e-external-aws-tmp-skip branch May 9, 2025 13:35
tbuskey pushed a commit to tbuskey/release that referenced this pull request May 19, 2025
…m fixes (openshift#64657)

Add skip to prevent permanent job failures caused by permanent test failures fixed in o/k repo.

The final solution are coordinated with several changes in the test framework, which depends on:

- https://issues.redhat.com/browse/SPLAT-2190: introduce external provider to the test framework 4.17-
- https://issues.redhat.com/browse/SPLAT-2191: update e2e step to set the provider across all jobs
    - openshift#64359 : once merged, fixes 4.18+, but 4.17- depends on SPLAT-2190
- [remove test skips for fixed permanent failures](https://issues.redhat.com/browse/SPLAT-2192)
tareqalayan pushed a commit to tareqalayan/release that referenced this pull request May 26, 2025
…m fixes (openshift#64657)

Add skip to prevent permanent job failures caused by permanent test failures fixed in o/k repo.

The final solution are coordinated with several changes in the test framework, which depends on:

- https://issues.redhat.com/browse/SPLAT-2190: introduce external provider to the test framework 4.17-
- https://issues.redhat.com/browse/SPLAT-2191: update e2e step to set the provider across all jobs
    - openshift#64359 : once merged, fixes 4.18+, but 4.17- depends on SPLAT-2190
- [remove test skips for fixed permanent failures](https://issues.redhat.com/browse/SPLAT-2192)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants