baremetal: remove filters for sig-network and any disconnected tests

[stbenjam]

This PR removes the filters for any tests that belong to sig-network or
do not work on disconnected. Some tests will be skipped in code in
openshift-tests, as there's now logic to filter disconnected tests out.

[openshift-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[stbenjam]

Just waiting on openshift/origin#26019, and I'll take this out of draft to see how it does on rehearse.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stbenjam
To complete the pull request process, please assign smarterclayton after the PR has been reviewed.
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/installer/OWNERS
• ci-operator/jobs/openshift/installer/OWNERS
• ci-operator/step-registry/baremetalds/OWNERS [stbenjam]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[stbenjam]

These tests still fail with "too many colons in address" (origin needs revendoring of openshift/kubernetes#628)

      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should allow egress access to server in CIDR block
      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should allow ingress access from updated namespace
      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should allow ingress access from updated pod
      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should deny ingress access to updated pod
      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should enforce egress policy allowing traffic to a server in a different namespace based on PodSelector and NamespaceSelectoE
      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should enforce except clause while egress access to server in CIDR block
      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should enforce multiple egress policies with egress allow-all policy taking precedence
      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should enforce multiple ingress policies with ingress allow-all policy taking precedence
      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should enforce multiple, stacked policies with overlapping podSelectors
      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should enforce policies to check ingress and egress policies can be controlled independently based on PodSelector
      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should enforce policy based on NamespaceSelector with MatchExpressions
      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should enforce policy based on PodSelector and NamespaceSelector
      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should enforce policy based on PodSelector or NamespaceSelector
      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should enforce policy based on PodSelector with MatchExpressions
      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should enforce policy based on Ports
      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should enforce policy to allow traffic from pods within server namespace based on PodSelector
      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should enforce policy to allow traffic only from a different namespace, based on NamespaceSelector
      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should enforce policy to allow traffic only from a pod in a different namespace based on PodSelector and NamespaceSelector
      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should enforce updated policy
      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should ensure an IP overlapping both IPBlock.CIDR and IPBlock.Except is allowed
      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should not allow access by TCP when a policy specifies only SCTP
      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should stop enforcing policies after they are deleted
      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should support a 'default-deny-all' policy
      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should support a 'default-deny-ingress' policy
      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should support allow-all policy
      \[sig-network\] NetworkPolicy \[LinuxOnly\] NetworkPolicy between server and client should work with Ingress,Egress specified together

This one needs to be added to the disconnected list (openshift/origin#26050)
[sig-network\] Networking should provide Internet connection for containers

[stbenjam]

/test pj-rehearse

[stbenjam]

IPv6 pass: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/17445/rehearse-17445-pull-ci-openshift-installer-master-e2e-metal-ipi-ovn-ipv6-trigger/1379808267013722112

Upgrade pass: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/17445/rehearse-17445-periodic-ci-openshift-release-master-nightly-4.8-e2e-metal-ipi-upgrade/1379808270104924160

IPv4 pass: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/17445/rehearse-17445-periodic-ci-openshift-release-master-nightly-4.8-e2e-metal-ipi-virtualmedia/1379572281990189056

Dualstack seems to be having issues with sig-builds, not sure why. :-\

[stbenjam]

/test pj-rehearse

[stbenjam]

These are failing on dualstack:

+      \[sig-builds\]\[Feature:Builds\] clone repository using git:// protocol  should clone using git:// if no proxy is configured
+      \[sig-builds\]\[Feature:Builds\] custom build with buildah  being created from new-build should complete build with custom builder image
+      \[sig-builds\]\[Feature:Builds\] imagechangetriggers  imagechangetriggers should trigger builds of all types
+      \[sig-builds\]\[Feature:Builds\] oc new-app  should fail with a --name longer than 58 characters
+      \[sig-builds\]\[Feature:Builds\] oc new-app  should succeed with a --name of 58 characters
+      \[sig-builds\]\[Feature:Builds\] oc new-app  should succeed with an imagestream
+      \[sig-builds\]\[Feature:Builds\] prune builds based on settings in the buildconfig  buildconfigs should have a default history limit set when created via the group api
+      \[sig-builds\]\[Feature:Builds\] prune builds based on settings in the buildconfig  should prune builds after a buildConfig change
+      \[sig-builds\]\[Feature:Builds\] prune builds based on settings in the buildconfig  should prune canceled builds based on the failedBuildsHistoryLimit setting
+      \[sig-builds\]\[Feature:Builds\] prune builds based on settings in the buildconfig  should prune completed builds based on the successfulBuildsHistoryLimit setting
+      \[sig-builds\]\[Feature:Builds\] prune builds based on settings in the buildconfig  should prune errored builds based on the failedBuildsHistoryLimit setting
+      \[sig-builds\]\[Feature:Builds\] prune builds based on settings in the buildconfig  should prune failed builds based on the failedBuildsHistoryLimit setting
+      \[sig-builds\]\[Feature:Builds\]\[valueFrom\] process valueFrom in build strategy environment variables  should fail resolving unresolvable valueFrom in docker build environment variable references
+      \[sig-builds\]\[Feature:Builds\]\[valueFrom\] process valueFrom in build strategy environment variables  should fail resolving unresolvable valueFrom in sti build environment variable references
+      \[sig-builds\]\[Feature:Builds\]\[valueFrom\] process valueFrom in build strategy environment variables  should successfully resolve valueFrom in docker build environment variables
+      \[sig-builds\]\[Feature:Builds\]\[valueFrom\] process valueFrom in build strategy environment variables  should successfully resolve valueFrom in s2i build environment variables
+      \[sig-imageregistry\]\[Feature:ImageTriggers\] Image change build triggers TestSimpleImageChangeBuildTriggerFromImageStreamTagSTI

Going to re-instate them while we investigate them as well.

[stbenjam]

/test pj-rehearse

[stbenjam]

/test pj-rehearse

[stbenjam]

/test pj-rehearse

[stbenjam]

/test pj-rehearse

[stbenjam]

/test pj-rehearse

[stbenjam]

/test pj-rehearse

[stbenjam]

/test pj-rehearse

[stbenjam]

/test pj-rehearse

[openshift-ci]

@stbenjam: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.8-e2e-metal-ipi-virtualmedia	84b2821e5c46e699f1154bdd32b3c0717e2ce40d	link	/test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.8-e2e-metal-ipi-compact	84b2821e5c46e699f1154bdd32b3c0717e2ce40d	link	/test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.8-e2e-metal-ipi-upgrade	84b2821e5c46e699f1154bdd32b3c0717e2ce40d	link	/test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.8-e2e-metal-ipi-serial-ipv4	84b2821e5c46e699f1154bdd32b3c0717e2ce40d	link	/test pj-rehearse
ci/rehearse/openshift/router/release-4.9/e2e-metal-ipi-ovn-ipv6	84b2821e5c46e699f1154bdd32b3c0717e2ce40d	link	/test pj-rehearse
ci/rehearse/openshift/cluster-network-operator/release-4.9/e2e-metal-ipi-ovn-ipv6-ipsec	84b2821e5c46e699f1154bdd32b3c0717e2ce40d	link	/test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-metal-ipi-ovn-dualstack-trigger	84b2821e5c46e699f1154bdd32b3c0717e2ce40d	link	/test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-metal-ipi-ovn-ipv6-trigger	84b2821e5c46e699f1154bdd32b3c0717e2ce40d	link	/test pj-rehearse
ci/rehearse/openshift/router/release-4.9/e2e-metal-ipi-ovn-router	84b2821e5c46e699f1154bdd32b3c0717e2ce40d	link	/test pj-rehearse
ci/prow/pj-rehearse	84b2821e5c46e699f1154bdd32b3c0717e2ce40d	link	/test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[ardaguclu]

/lgtm

[stbenjam]

/hold cancel

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/baremetalds/OWNERS [stbenjam]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[stbenjam]

We've seen this PR pass the variations of metal at least once: #17445 (comment). We also see it pass locally in our dev environments.

It's hard to get pj-rehearse to pick the exact jobs we want, so we've agreed to land this, and I'll watch the release dashboard carefully today just in case we missed something.

[openshift-ci]

@stbenjam: Updated the step-registry configmap in namespace ci at cluster app.ci using the following files:

• key baremetalds-devscripts-setup-commands.sh using file ci-operator/step-registry/baremetalds/devscripts/setup/baremetalds-devscripts-setup-commands.sh
• key baremetalds-e2e-test-commands.sh using file ci-operator/step-registry/baremetalds/e2e/test/baremetalds-e2e-test-commands.sh
• key baremetalds-e2e-test-ref.yaml using file ci-operator/step-registry/baremetalds/e2e/test/baremetalds-e2e-test-ref.yaml

Details

In response to this:

This PR removes the filters for any tests that belong to sig-network or
do not work on disconnected. Some tests will be skipped in code in
openshift-tests, as there's now logic to filter disconnected tests out.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.