Skip to content

Comments

Use baremetal test provider#17027

Closed
andfasano wants to merge 2 commits intoopenshift:masterfrom
andfasano:baremetal-provider
Closed

Use baremetal test provider#17027
andfasano wants to merge 2 commits intoopenshift:masterfrom
andfasano:baremetal-provider

Conversation

@andfasano
Copy link
Contributor

@andfasano andfasano commented Mar 22, 2021 •
edited
Loading

This PR adds the usage of the baremetal test provider introduced in openshift/origin#25994

cc @stbenjam

@andfasano andfasano changed the title [WIPAdd baremetal test provider [WIP] Use baremetal test provider Mar 22, 2021
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 22, 2021
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2021
stbenjam
stbenjam reviewed Mar 22, 2021
View reviewed changes
ci-operator/step-registry/baremetalds/e2e/test/baremetalds-e2e-test-commands.sh Outdated
Copy link
Member

@stbenjam stbenjam Mar 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to escape the quotes when I was testing this the other day, as this is passed over ssh later on

https://github.com/openshift/release/pull/16986/files#diff-7b4946fc316154f2f0fe2beac2371cf82bc14d8071298890e8a014417e88159fR50

Copy link
Contributor Author

@andfasano andfasano Mar 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@andfasano andfasano force-pushed the baremetal-provider branch from 9feddaf to 4384cd0 Compare March 22, 2021 15:29
@stbenjam
Copy link
Member

stbenjam commented Mar 22, 2021

/test pj-rehearse

3 similar comments
@stbenjam
Copy link
Member

stbenjam commented Mar 22, 2021

/test pj-rehearse

@stbenjam
Copy link
Member

stbenjam commented Mar 23, 2021

/test pj-rehearse

@andfasano
Copy link
Contributor Author

andfasano commented Mar 23, 2021

/test pj-rehearse

@stbenjam
Copy link
Member

stbenjam commented Mar 23, 2021

Needs to be imported so init() gets run:openshift/origin#26007

@stbenjam
Copy link
Member

stbenjam commented Mar 23, 2021

/test pj-rehearse

@andfasano andfasano changed the title [WIP] Use baremetal test provider Use baremetal test provider Mar 24, 2021
@andfasano
Copy link
Contributor Author

andfasano commented Mar 24, 2021

/test pj-rehearse

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 24, 2021
@andfasano
Copy link
Contributor Author

andfasano commented Mar 30, 2021

/test pj-rehearse

@stbenjam
Copy link
Member

stbenjam commented Mar 30, 2021

Could we also remove all the Skipped:Network/ from our TEST_SKIPS if we're turning on the provider? Those should all work now.

@andfasano andfasano force-pushed the baremetal-provider branch from 4384cd0 to d3250fa Compare March 31, 2021 07:33
@andfasano
Copy link
Contributor Author

andfasano commented Mar 31, 2021

/test pj-rehearse

@stbenjam
Copy link
Member

stbenjam commented Mar 31, 2021

I think we want to trigger IPv6 and dualstack to make sure it works there

@stbenjam
Copy link
Member

stbenjam commented Mar 31, 2021

Also this change will fail on < 4.8 since it's not backported there :-(

@stbenjam
Copy link
Member

stbenjam commented Apr 1, 2021

Failing tests don't look related, and are different on each one :(

/test pj-rehearse

@andfasano
Copy link
Contributor Author

andfasano commented Apr 2, 2021

/test pj-rehearse

@andfasano andfasano force-pushed the baremetal-provider branch from d3250fa to c7924de Compare April 6, 2021 10:38
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2021

@andfasano: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/cluster-baremetal-operator/release-4.6/e2e-metal-ipi 4384cd090aac85f0d8931fc3e70ceffb40bc2c4f link /test pj-rehearse
ci/rehearse/openshift/baremetal-operator/master/e2e-metal-ipi d3250fae5d173cc0fb175c250661a802df8df61d link /test pj-rehearse
ci/rehearse/openshift/baremetal-operator/master/e2e-metal-ipi-virtualmedia d3250fae5d173cc0fb175c250661a802df8df61d link /test pj-rehearse
ci/rehearse/openshift/cluster-api-provider-baremetal/master/e2e-metal-ipi-upgrade d3250fae5d173cc0fb175c250661a802df8df61d link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.8-e2e-metal-ipi-upgrade d3250fae5d173cc0fb175c250661a802df8df61d link /test pj-rehearse
ci/rehearse/openshift/router/release-4.9/e2e-metal-ipi-ovn-router d3250fae5d173cc0fb175c250661a802df8df61d link /test pj-rehearse
ci/prow/pj-rehearse d3250fae5d173cc0fb175c250661a802df8df61d link /test pj-rehearse
ci/rehearse/openshift/router/release-4.9/e2e-metal-ipi-ovn-ipv6 c7924de link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andfasano
Copy link
Contributor Author

andfasano commented Apr 6, 2021

Addressed by #17445

@andfasano andfasano closed this Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akiselev1 akiselev1 Awaiting requested review from akiselev1

@honza honza Awaiting requested review from honza

1 more reviewer

@stbenjam stbenjam stbenjam left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andfasano @openshift-ci-robot @stbenjam