Skip to content

Comments

Bug 1962905: Revert "Disable caching live boot iso by default"#172

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
celebdor:revert-http-default-live-iso-source
May 24, 2021
Merged

Bug 1962905: Revert "Disable caching live boot iso by default"#172
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
celebdor:revert-http-default-live-iso-source

Conversation

@celebdor
Copy link

Ironic's approach to caching ISOs and serving them to Apache is well supported by most BMCs and defaulting to it would increase the compatibility of the solution. Switching the default to "local" should come with documentation of the storage requirements, specially in the usage pattern introduced by the Agent based fully automated provisioning.

This reverts commit 39bd4c5.

@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label May 20, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 20, 2021

@celebdor: This pull request references Bugzilla bug 1962905, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @chadcrum

Details

In response to this:

Bug 1962905: Revert "Disable caching live boot iso by default"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 20, 2021
@celebdor celebdor mentioned this pull request May 20, 2021
@elfosardo
Copy link

/test prevalidation-e2e-metal-ipi-prevalidation

@elfosardo
Copy link

/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

@elfosardo
Copy link

/test e2e-metal-ipi

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2021
@dtantsur
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@chadcrum
Copy link

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented May 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: celebdor, chadcrum, dtantsur, elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@romfreiman
Copy link

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@stbenjam
Copy link
Member

I don't know why the prevalidation test is failing various unit tests (some of these were recently enabled in openshift/release#17445 and openshift/release#18583).

AFAIK these jobs are only used when we're testing new ironic packages. This is blocking some critical customer work, so I'm going to override it.

/override ci/prow/prevalidation-e2e-metal-ipi-prevalidation

@openshift-ci
Copy link

openshift-ci bot commented May 23, 2021

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/prevalidation-e2e-metal-ipi-prevalidation

Details

In response to this:

I don't know why the prevalidation test is failing various unit tests (some of these were recently enabled in openshift/release#17445 and openshift/release#18583).

AFAIK these jobs are only used when we're testing new ironic packages. This is blocking some critical customer work, so I'm going to override it.

/override ci/prow/prevalidation-e2e-metal-ipi-prevalidation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@stbenjam
Copy link
Member

/override ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation
/override ci/prow/prevalidation-e2e-metal-ipi-prevalidation

@openshift-ci
Copy link

openshift-ci bot commented May 23, 2021

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/prevalidation-e2e-metal-ipi-prevalidation, ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation

Details

In response to this:

/override ci/prow/prevalidation-e2e-metal-ipi-virtualmedia-prevalidation
/override ci/prow/prevalidation-e2e-metal-ipi-prevalidation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@stbenjam
Copy link
Member

/override ci/prow/prevalidation-e2e-metal-ipi-prevalidation

@openshift-ci
Copy link

openshift-ci bot commented May 24, 2021

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/prevalidation-e2e-metal-ipi-prevalidation

Details

In response to this:

/override ci/prow/prevalidation-e2e-metal-ipi-prevalidation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member

/override ci/prow/e2e-metal-ipi

The test failures are well past where Ironic is relevant.

@openshift-ci
Copy link

openshift-ci bot commented May 24, 2021

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-metal-ipi

Details

In response to this:

/override ci/prow/e2e-metal-ipi

The test failures are well past where Ironic is relevant.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit c785118 into openshift:master May 24, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 24, 2021

@celebdor: All pull requests linked via external trackers have merged:

Bugzilla bug 1962905 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1962905: Revert "Disable caching live boot iso by default"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/ironic-image that referenced this pull request Oct 25, 2022
Configure ironic to use Ipmitool retries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants