Skip to content

Comments

baremetal: add back admission controller test to skips#18769

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
stbenjam:fix-ipv6
May 21, 2021
Merged

baremetal: add back admission controller test to skips#18769
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
stbenjam:fix-ipv6

Conversation

@stbenjam
Copy link
Member

@stbenjam stbenjam commented May 21, 2021

This test won't pass on IPv6, as it hardcodes IPv4 cluster service IP. I mistakenly removed this in #17445.

This test won't pass on IPv6, as it hardcodes IPv4 cluster service IP.
@openshift-ci openshift-ci bot requested review from akiselev1 and derekhiggins May 21, 2021 22:04
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2021
@stbenjam
Copy link
Member Author

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2021

@stbenjam: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stbenjam
Copy link
Member Author

Thanks!

@openshift-merge-robot openshift-merge-robot merged commit 00f1822 into openshift:master May 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2021

@stbenjam: Updated the step-registry configmap in namespace ci at cluster app.ci using the following files:

  • key baremetalds-e2e-test-ref.yaml using file ci-operator/step-registry/baremetalds/e2e/test/baremetalds-e2e-test-ref.yaml
Details

In response to this:

This test won't pass on IPv6, as it hardcodes IPv4 cluster service IP. I mistakenly removed this in #17445.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam stbenjam deleted the fix-ipv6 branch May 22, 2021 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants