Skip to content

Comments

test: skip internet check on disconnected#26050

Closed
stbenjam wants to merge 1 commit intoopenshift:masterfrom
stbenjam:disconnected
Closed

test: skip internet check on disconnected#26050
stbenjam wants to merge 1 commit intoopenshift:masterfrom
stbenjam:disconnected

Conversation

@stbenjam
Copy link
Member

@stbenjam stbenjam commented Apr 7, 2021

[sig-network] Networking should provide Internet connection for containers should not run on disconnected environments.

`[sig-network] Networking should provide Internet connection for
containers` should not run on disconnected environments.
@ardaguclu
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ardaguclu, stbenjam
To complete the pull request process, please assign smarterclayton after the PR has been reviewed.
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ardaguclu
Copy link
Member

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 16, 2021

@stbenjam: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 2e44586 link /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-disruptive 2e44586 link /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@danwinship
Copy link
Contributor

this has been absorbed into #26051
/close

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

@stbenjam: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Jun 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

@danwinship: Closed this PR.

Details

In response to this:

this has been absorbed into #26051
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants