Skip to content

Comments

test: provide a way to skip tests on disconnected clusters#26019

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
stbenjam:skipped-disconnected
Apr 6, 2021
Merged

test: provide a way to skip tests on disconnected clusters#26019
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
stbenjam:skipped-disconnected

Conversation

@stbenjam
Copy link
Member

@stbenjam stbenjam commented Mar 25, 2021

There are a variety of tests that do not pass on disconnected, either
because they require outbound internet access (s2i builds that use a
GitHub repo), or are affected by the image registry not support ICSP[1].

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1918376

@stbenjam stbenjam force-pushed the skipped-disconnected branch from b4ae8ea to f607542 Compare March 25, 2021 16:54
@stbenjam stbenjam changed the title test: provide a way to skip tests on disconencted clusters test: provide a way to skip tests on disconnected clusters Mar 25, 2021
@stbenjam stbenjam force-pushed the skipped-disconnected branch from f607542 to a6c4a5d Compare March 25, 2021 17:27
smarterclayton
smarterclayton reviewed Mar 25, 2021
View reviewed changes
@stbenjam stbenjam force-pushed the skipped-disconnected branch from a6c4a5d to 8512e5d Compare March 25, 2021 19:30
smarterclayton
smarterclayton reviewed Mar 25, 2021
View reviewed changes
@stbenjam stbenjam force-pushed the skipped-disconnected branch 2 times, most recently from 099547f to b250034 Compare March 26, 2021 00:47
@andfasano andfasano mentioned this pull request Mar 26, 2021
Closed
@andfasano
Copy link
Contributor

andfasano commented Mar 26, 2021

/test e2e-metal-ipi-ovn-ipv6

@stbenjam
Copy link
Member Author

stbenjam commented Mar 26, 2021

Something seems to be wrong with ovn-ipv6, investigating.. :-\

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2021
smarterclayton
smarterclayton reviewed Mar 29, 2021
View reviewed changes
@stbenjam stbenjam force-pushed the skipped-disconnected branch from b250034 to 22a608a Compare March 30, 2021 11:59
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2021
@stbenjam stbenjam force-pushed the skipped-disconnected branch from 22a608a to 200efe1 Compare March 30, 2021 12:02
@smarterclayton
Copy link
Contributor

smarterclayton commented Mar 30, 2021

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 30, 2021
@stbenjam
Copy link
Member Author

stbenjam commented Mar 30, 2021

/hold

Some of the rules are messed up

clone repository using git:// protocol should clone using git:// has 2 spaces between protocol and should, but I copied my list of failures out of spyglass and HTML ate the extra whitespace.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2021
@stbenjam
test: provide a way to skip tests on disconnected clusters
962a9c4 
There are a variety of tests that do not pass on disconnected, either
because they require outbound internet access (s2i builds that use a
GitHub repo), or are affected by the image registry not support ICSP[1].

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1918376
@stbenjam stbenjam force-pushed the skipped-disconnected branch from 200efe1 to 962a9c4 Compare March 31, 2021 10:44
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2021
@ardaguclu
Copy link
Member

ardaguclu commented Mar 31, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 31, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, smarterclayton, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stbenjam
Copy link
Member Author

stbenjam commented Mar 31, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2021
@stbenjam
Copy link
Member Author

stbenjam commented Mar 31, 2021

Metal failing since it our skip list included the full name, so now it doesn't match with [Skipped:Disconnected] -- openshift/release#17352 should fix it

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 31, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 31, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 1, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 1, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 1, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 1, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@stbenjam
Copy link
Member Author

stbenjam commented Apr 1, 2021

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2021
@danwinship danwinship mentioned this pull request Apr 5, 2021
Merged
@stbenjam
Copy link
Member Author

stbenjam commented Apr 6, 2021

/retest

@stbenjam
Copy link
Member Author

stbenjam commented Apr 6, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2021
@stbenjam
Copy link
Member Author

stbenjam commented Apr 6, 2021

/retest

@stbenjam stbenjam mentioned this pull request Apr 6, 2021
Merged
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 6, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7f6c321 into openshift:master Apr 6, 2021
@stbenjam stbenjam deleted the skipped-disconnected branch April 6, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

@pweil- pweil- Awaiting requested review from pweil-

1 more reviewer

@smarterclayton smarterclayton smarterclayton left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@smarterclayton smarterclayton

@ardaguclu ardaguclu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@stbenjam @andfasano @smarterclayton @ardaguclu @openshift-ci-robot @openshift-bot @openshift-merge-robot