Bug 1873043: Revise test annotation to reuse rules+code from openshift/kubernetes #25382
Conversation
openshift-ci-robot
requested review from
deads2k,
mfojtik,
smarterclayton and
sttts
openshift-ci-robot
added
do-not-merge/work-in-progress
|
/retest |
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
marun
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest |
5 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
openshift-ci-robot
added
the
needs-rebase
The previous shortcut in updating staging repos breaks when the local repo contains tags that are not present in openshift/kubernetes.
The test annotation code and rules in this repo have been updated to rely on code and rules vendored from openshift/kubernetes. The rules defined in this repo are intended to apply to openshift-only tests and platforms, since rules about kube e2e are inherited from openshift/kubernetes. Responsibility for maintaining the test annotation code and kube e2e rules was moved to openshift/kubernetes to allow for an openshift-compatible kube e2e job to gate openshift/kubernetes PRs. Such a job can ensure that a PR that includes test changes will be validated against those changes in advance of their incorporation into an openshift-tests binary built from origin.
openshift-ci-robot
removed
the
needs-rebase
marun
changed the title
|
@marun: This pull request references Bugzilla bug 1873043, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-urgent
|
I'm abusing the 1.19.0 bump bz because this PR really should have landed at the same time as the 1.19.0-rc.2 PR. Having it remain unmerged has meant lots of manual work to synchronize changes to kube e2e updates to rules.go back to openshift/kubernetes. The origin bump to 1.19.0 will pick those changes back up. |
| `Multi-AZ Clusters should spread the pods of a replication controller across zones`, | ||
|
|
||
| // Disabled as per networking team. Follow-up tracked via https://bugzilla.redhat.com/show_bug.cgi?id=1861214 | ||
| `EndpointSliceMirroring should mirror a custom Endpoints resource through create update and delete`, |
There was a problem hiding this comment.
you went through all of these and made sure that only match kube tests?
There was a problem hiding this comment.
The reverse. The rules in this file only match origin tests. As per the comment at the top of the file, the openshift/kubernetes equivalent only matches kube tests.
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/lgtm README update. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marun, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@marun: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@marun: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Bugzilla bug 1873043 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
The test annotation code and rules in this repo have been updated to rely on code and rules vendored from openshift/kubernetes. The rules defined in this repo are intended to apply to openshift-only tests and platforms, since rules about kube e2e are inherited from openshift/kubernetes.
Responsibility for maintaining the test annotation code and kube e2e rules was moved to openshift/kubernetes to allow for an openshift-compatible kube e2e job to gate openshift/kubernetes PRs. Such a job can ensure that a PR that includes test changes will be validated against those changes in advance of their incorporation into an openshift-tests binary built from origin.
/cc @sttts @mfojtik @smarterclayton @deads2k