Skip to content

Bug 1873043: Stop annotating origin tests with [Suite:openshift] #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 29, 2020
Merged

Bug 1873043: Stop annotating origin tests with [Suite:openshift] #377

openshift-merge-robot merged 1 commit into from
Sep 29, 2020

Conversation

@marun
Copy link

@marun marun commented Sep 28, 2020

The detection logic was error-prone (different results based on the repo existing in GOPATH vs not) and whether a test comes from origin can be inferred from the absence of the [Suite:k8s] tag.

@marun
UPSTREAM: <carry>: (squash) Stop annotating origin tests with [Suite:…
b4914bc 
…openshift]

The detection logic was error-prone (different results based on the
repo existing in GOPATH vs not) and whether a test comes from origin
can be inferred from the absence of the `[Suite:k8s]` tag.

Suggest squashing with UPSTREAM: <carry>: Build openshift-compatible e2e binary
@marun marun mentioned this pull request Sep 28, 2020
Merged
@smarterclayton
Copy link

smarterclayton commented Sep 29, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2020
@smarterclayton smarterclayton added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 29, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ironcladlou ironcladlou mentioned this pull request Sep 29, 2020
Closed
@marun marun changed the title Stop annotating origin tests with [Suite:openshift] Bug 1873043: Stop annotating origin tests with [Suite:openshift] Sep 29, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 29, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 29, 2020

@marun: This pull request references Bugzilla bug 1873043, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1873043: Stop annotating origin tests with [Suite:openshift]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 29, 2020
@marun
Copy link
Author

marun commented Sep 29, 2020

Abusing 1.19 bz because this is a dev-only issue related to the 1.19 rebase.

@marun
Copy link
Author

marun commented Sep 29, 2020

/retest

@openshift-bot
Copy link

openshift-bot commented Sep 29, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit beb741b into openshift:master Sep 29, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 29, 2020

@marun: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1873043 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1873043: Stop annotating origin tests with [Suite:openshift]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Nov 3, 2020
Merged
12 tasks
@openshift-ci-robot openshift-ci-robot mentioned this pull request Nov 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@bparees bparees Awaiting requested review from bparees

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@smarterclayton smarterclayton

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@marun @smarterclayton @openshift-ci-robot @openshift-bot @openshift-merge-robot