Skip to content

Bug 1873043: Update README.openshift to reflect transition to openshift/kubernetes #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 29, 2020
Merged

Bug 1873043: Update README.openshift to reflect transition to openshift/kubernetes #366

openshift-merge-robot merged 1 commit into from
Sep 29, 2020

Conversation

@marun
Copy link

@marun marun commented Sep 21, 2020 •
edited
Loading

No description provided.

@marun marun requested review from p0lyn0mial, soltysh, sttts and tnozicka and removed request for bparees and smarterclayton September 21, 2020 23:55
sttts
sttts reviewed Sep 22, 2020
View reviewed changes
@marun
Copy link
Author

marun commented Sep 22, 2020

/retest

@marun marun changed the title Update README.openshift to reflect transition to openshift/kubernetes Bug 1873043: Update README.openshift to reflect transition to openshift/kubernetes Sep 22, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 22, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 22, 2020

@marun: This pull request references Bugzilla bug 1873043, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1873043: Update README.openshift to reflect transition to openshift/kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 22, 2020
@marun
Copy link
Author

marun commented Sep 22, 2020

/retest

1 similar comment
@marun
Copy link
Author

marun commented Sep 22, 2020

/retest

This was referenced Sep 23, 2020
Merged
Merged
Merged
sttts
sttts reviewed Sep 28, 2020
View reviewed changes
README.openshift.md Outdated
Copy link

@sttts sttts Sep 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this description here at all? How is o/k special as a consumer of library-go? I would expect this merely distributed over api, client-go and library-go repos.

Copy link

@sttts sttts Sep 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would remove the whole list of steps here.

Copy link
Author

@marun marun Sep 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

sttts
sttts reviewed Sep 28, 2020
View reviewed changes
README.openshift.md Outdated
Copy link

@sttts sttts Sep 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think this block is strange. What are external API objects?

"which holds the actual code behind OpenShift." does not really make sense. Correct: "o/k – the core Kubernetes components with OpenShift specific patches".

Copy link
Author

@marun marun Sep 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@marun
UPSTREAM: <carry>: (squash) Update README.openshift to reflect transi…
7eb4331 
…tion

Suggest squashing with rebase instruction changes into a generic
'Maintain openshift docs' commit.
@sttts
Copy link

sttts commented Sep 28, 2020

/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 28, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 28, 2020
@openshift-bot
Copy link

openshift-bot commented Sep 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link

openshift-bot commented Sep 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Sep 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Sep 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Sep 28, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit bafba66 into openshift:master Sep 29, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 29, 2020

@marun: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1873043 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1873043: Update README.openshift to reflect transition to openshift/kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Sep 29, 2020
Merged
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Nov 3, 2020
Merged
12 tasks
@openshift-ci-robot openshift-ci-robot mentioned this pull request Nov 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soltysh soltysh Awaiting requested review from soltysh

@tnozicka tnozicka Awaiting requested review from tnozicka

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

1 more reviewer

@sttts sttts sttts left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sttts sttts

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@marun @openshift-ci-robot @sttts @openshift-bot @openshift-merge-robot