Bug 1873043: Fix annotation generation #25565

marun · 2020-09-28T21:45:48Z

Previously the check for whether a test should be annotated for the origin suite ([Suite:openshift]) depended on the repo clone being in a GOPATH (i.e. src/github.com/openshift/origin). openshift/kubernetes#377 avoids this problem by disabling the addition of the annotation - whether a test is defined in origin can be inferred by the absence of the [Suite:k8s] annotation. This PR bumps openshift/kubernetes to pick up that change and updates the annotations

/cc @ironcladlou @smarterclayton

openshift-ci-robot · 2020-09-29T21:32:30Z

@marun: An error was encountered adding this pull request to the external tracker bugs for bug 1873043 on the Bugzilla server at https://bugzilla.redhat.com:

JSONRPC error 32000: There was an error reported for a GitHub REST call. URL: https://api.github.com/repos/openshift/origin/pulls/25565 Error: 403 Forbidden at /loader/0x5589446ba9a8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. at /loader/0x5589446ba9a8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. eval {...} called at /loader/0x5589446ba9a8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 98 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x55894e...', 'https://api.github.com/repos/openshift/origin/pulls/25565', 'GET') called at /loader/0x5589446ba9a8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x55894e...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x55894c0f23c0)') called at /loader/0x5589446ba9a8/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x5589446ba9a8/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x55894c0f23c0)', 1) called at /loader/0x5589446ba9a8/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x55894e5d5a00)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 877 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x55894e4747a0)', 'HASH(0x55894e3c80c8)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x55894e3c80c8)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1170 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x55894e5f3a30)') called at /loader/0x5589446ba9a8/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x5589525cd468)') called at (eval 2611) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x558951f78d58)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 295 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x558951f78d58)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x55894e5da1e0)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x5589525bfec0)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x5589525bfec0)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x55894e5da1e0)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x55894e5da1e0)') called at (eval 2611) line 0 eval {...} called at (eval 2611) line 0
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

Bug 1873043: Fix annotation generation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-09-29T21:35:07Z

@marun: This pull request references Bugzilla bug 1873043, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1873043: Fix annotation generation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-09-29T21:35:40Z

@marun: This pull request references Bugzilla bug 1873043, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1873043: Fix annotation generation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Also update go.mod golang version to 1.15.

openshift-ci-robot · 2020-09-30T15:55:27Z

@marun: This pull request references Bugzilla bug 1873043, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1873043: Fix annotation generation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

marun · 2020-09-30T16:06:01Z

/test e2e-gcp-upgrade

sttts · 2020-09-30T16:12:50Z

/lgtm
/approve

Testing only change.

openshift-bot · 2020-09-30T16:37:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-30T16:50:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-30T17:16:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

marun · 2020-09-30T17:40:08Z

/bugzilla refresh

openshift-ci-robot · 2020-09-30T17:40:10Z

@marun: This pull request references Bugzilla bug 1873043, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

marun · 2020-09-30T17:40:45Z

/bugzilla refresh

openshift-ci-robot · 2020-09-30T17:40:49Z

@marun: This pull request references Bugzilla bug 1873043, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-09-30T18:34:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-30T18:47:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-30T20:05:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-30T20:31:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-30T21:22:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

marun · 2020-09-30T22:20:23Z

Updated to fix upgrade test matching (previously relied on [Suite:openshift], now relies on the absence of [Suite:k8s]).

sttts · 2020-10-01T07:42:46Z

/lgtm

openshift-ci-robot · 2020-10-01T07:43:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-10-01T07:46:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T08:38:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T08:51:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T10:09:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T10:52:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T11:40:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T18:49:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-02T01:06:18Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-02T01:19:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-02T03:16:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-02T03:29:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-10-02T05:19:14Z

@marun: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

openshift/kubernetes#361 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1873043 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1873043: Fix annotation generation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from ironcladlou and smarterclayton September 28, 2020 21:45

openshift-ci-robot added the vendor-update Touching vendor dir or related files label Sep 28, 2020

marun changed the title ~~Fix annotation generation~~ WIP Fix annotation generation Sep 28, 2020

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 28, 2020

marun mentioned this pull request Sep 28, 2020

Add a new baseline performance test #25562

Closed

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2020

marun changed the title ~~WIP Fix annotation generation~~ Bug 1873043: Fix annotation generation Sep 29, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2020

openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 29, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 29, 2020

marun added 2 commits September 29, 2020 14:37

Bump(github.com/openshift/kubernetes)

b2eefde

Also update go.mod golang version to 1.15.

make update

9d98963

openshift-ci-robot assigned sttts Sep 30, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 30, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 30, 2020

Update upgrade testmatching from [Suite:openshift] => not [Suite:k8s]

b7677b8

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2020

openshift-merge-robot merged commit e1481ed into openshift:master Oct 2, 2020

openshift-ci-robot mentioned this pull request Nov 3, 2020

Bug 1873043: Rebase to 1.19.2 openshift/kubernetes#361

Merged

12 tasks

openshift-ci-robot mentioned this pull request Nov 10, 2020

Bug 1873043: Rebase to kube 1.19.2 #25659

Merged

Bug 1873043: Fix annotation generation #25565

Bug 1873043: Fix annotation generation #25565

Uh oh!

Conversation

marun commented Sep 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 29, 2020

Uh oh!

openshift-ci-robot commented Sep 29, 2020

Uh oh!

openshift-ci-robot commented Sep 29, 2020

Uh oh!

openshift-ci-robot commented Sep 30, 2020

Uh oh!

marun commented Sep 30, 2020

Uh oh!

sttts commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

marun commented Sep 30, 2020

Uh oh!

openshift-ci-robot commented Sep 30, 2020

Uh oh!

marun commented Sep 30, 2020

Uh oh!

openshift-ci-robot commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

marun commented Sep 30, 2020

Uh oh!

sttts commented Oct 1, 2020

Uh oh!

openshift-ci-robot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 2, 2020

Uh oh!

openshift-bot commented Oct 2, 2020

Uh oh!

openshift-bot commented Oct 2, 2020

Uh oh!

openshift-bot commented Oct 2, 2020

Uh oh!

openshift-ci-robot commented Oct 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

marun commented Sep 28, 2020 •

edited

Loading