csi: add configobserver controller and hook helpers #976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertinatto
force-pushed
the
csi-proxy
branch
6 times, most recently
from
5d30bec to
2a4c239
Compare
bertinatto
changed the title
bertinatto
force-pushed
the
csi-proxy
branch
3 times, most recently
from
006efef to
b6a80c9
Compare
bertinatto
commented
Jan 8, 2021
bertinatto
force-pushed
the
csi-proxy
branch
4 times, most recently
from
dcf095c to
6812af3
Compare
bertinatto
changed the title
gnufied
reviewed
Jan 11, 2021
pkg/operator/csi/csidrivercontrollerservicecontroller/helpers.go
Outdated
Show resolved
Hide resolved
gnufied
reviewed
Jan 11, 2021
pkg/operator/csi/csiconfigobservercontroller/csi_config_observer_controller.go
Outdated
Show resolved
Hide resolved
gnufied
reviewed
Jan 11, 2021
pkg/operator/csi/csidrivercontrollerservicecontroller/helpers.go
Outdated
Show resolved
Hide resolved
gnufied
reviewed
Jan 11, 2021
pkg/operator/csi/csidrivercontrollerservicecontroller/helpers.go
Outdated
Show resolved
Hide resolved
gnufied
reviewed
Jan 11, 2021
| deployment.Spec.Template.Annotations = map[string]string{} | ||
| } | ||
| for k, v := range inputHashes { | ||
| annotationKey := fmt.Sprintf("operator.openshift.io/dep-%s", k) |
Member
There was a problem hiding this comment.
lets move this into a var/constant
Member
Author
There was a problem hiding this comment.
I'd like to leave this on as is. I prefer to leave format strings inline, plus I couldn't re-use the const for the annotation below (%x != %s)
bertinatto
force-pushed
the
csi-proxy
branch
2 times, most recently
from
3f41a0a to
b42db8c
Compare
Member
|
/lgtm |
deads2k
reviewed
Jan 12, 2021
...perator/csi/csidrivercontrollerservicecontroller/csi_driver_controller_service_controller.go
Show resolved
Hide resolved
deads2k
reviewed
Jan 12, 2021
Contributor
|
I think https://github.com/openshift/library-go/pull/976/files#r556138811 is my only blocker before approval. Good PR. |
openshift-ci-robot
added
the
needs-rebase
Cloud CSI drivers perform all sorts of operations using the cloud API. However, that's not possible in network-restricted clusters, where requests need to go through a given proxy, unless they target the API server. This patch adds a CSI Config Observer controller to observe the proxy resource and record the information in the operator CR. It also adds a hook function to inject the observed proxy config into the deployment's containers.
openshift-ci-robot
removed
the
needs-rebase
Member
Author
|
/test all |
Contributor
|
/refresh |
Contributor
|
Thanks, /approve |
openshift-ci-robot
added
the
approved
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, deads2k, gnufied The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/refresh |
This was referenced Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new functionalities to the CSI pieces of library-go:
csi: add configobserver to watch proxy info
Cloud CSI drivers perform all sorts of operations using the cloud API. However, that's not possible in network-restricted clusters, where requests need to go through a given proxy, unless they target the API server.
This patch adds a CSI Config Observer controller to observe the proxy resource and record the information in the operator CR. It also patches the CSI Controller Service Controller to read this information and pass it to the CSI containers that are part of the Deployment.
csi: add hook that annotates deployment with secret's hash
This is useful for when the secret changes. In this case we want the deployment to be re-deployed.
/assign @deads2k