Skip to content

Bug 1898045: redeploy CSI Controller Deployment when secret changes #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Jan 14, 2021
Merged

Bug 1898045: redeploy CSI Controller Deployment when secret changes #107

openshift-merge-robot merged 2 commits into from
Jan 14, 2021

Conversation

@bertinatto
Copy link
Member

@bertinatto bertinatto commented Jan 11, 2021

This PR uses changes from openshift/library-go#976 to redeploy the Controller Deployment when the secret changes.

CC @openshift/storage

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jan 11, 2021
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 11, 2021

@bertinatto: This pull request references Bugzilla bug 1898045, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1898045: Add secret hash annotation to Deployment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 11, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2021
@bertinatto
Copy link
Member Author

bertinatto commented Jan 11, 2021

/hold
openshift/library-go#976 needs to be merged first.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2021
@bertinatto bertinatto changed the title Bug 1898045: Add secret hash annotation to Deployment Bug 1898045: redeploy CSI Controller Deployment when secret changes Jan 12, 2021
@bertinatto
Copy link
Member Author

bertinatto commented Jan 13, 2021

/refresh

@bertinatto
Copy link
Member Author

bertinatto commented Jan 13, 2021

/hold cancel
openshift/library-go#976 has been merged.
@openshift/storage PTAL

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2021
@huffmanca
Copy link
Contributor

huffmanca commented Jan 13, 2021

/retest

@gnufied
Copy link
Member

gnufied commented Jan 13, 2021

Having reviewed the library-go changes, these changes look good to me.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2021
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 13, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 13, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit bdfda76 into openshift:master Jan 14, 2021
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 14, 2021

@bertinatto: All pull requests linked via external trackers have merged:

Bugzilla bug 1898045 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1898045: redeploy CSI Controller Deployment when secret changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bertinatto bertinatto mentioned this pull request Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

@tsmetana tsmetana Awaiting requested review from tsmetana

Assignees

@gnufied gnufied

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bertinatto @openshift-ci-robot @huffmanca @gnufied @openshift-bot @openshift-merge-robot