Skip to content

Bug 1910459: redeploy CSI Controller Deployment when secret changes #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 14, 2021
Merged

Bug 1910459: redeploy CSI Controller Deployment when secret changes #9

openshift-merge-robot merged 1 commit into from
Jan 14, 2021

Conversation

@bertinatto
Copy link
Member

@bertinatto bertinatto commented Jan 7, 2021 •
edited
Loading

This PR uses changes from openshift/library-go#976 to redeploy the Controller Deployment when the secret changes.

CC @openshift/storage

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 7, 2021
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 7, 2021

@bertinatto: This pull request references Bugzilla bug 1910459, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1910459: redeploy CSI Controller Deployment when secret changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2021
@bertinatto bertinatto force-pushed the secret-hook branch 2 times, most recently from a1ab7b2 to 23f691a Compare January 7, 2021 20:50
@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2021
bertinatto
bertinatto commented Jan 7, 2021
View reviewed changes
Copy link
Member Author

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
to check an issue with the lister.

@bertinatto
Copy link
Member Author

bertinatto commented Jan 8, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2021
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 8, 2021

@bertinatto: This pull request references Bugzilla bug 1910459, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1910459: redeploy CSI Controller Deployment when secret changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bertinatto
Copy link
Member Author

bertinatto commented Jan 8, 2021

/hold
openshift/library-go#976 needs to be reviewed/approved/merged first.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2021
@bertinatto bertinatto force-pushed the secret-hook branch 6 times, most recently from 4eed3d7 to 323267e Compare January 13, 2021 21:17
@bertinatto
Copy link
Member Author

bertinatto commented Jan 13, 2021

/hold cancel

openshift/library-go#976 has been merged.

@bertinatto
Copy link
Member Author

bertinatto commented Jan 13, 2021

/refresh

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2021
@bertinatto
Copy link
Member Author

bertinatto commented Jan 13, 2021

@openshift/storage PTAL

@bertinatto
Copy link
Member Author

bertinatto commented Jan 13, 2021

/refresh

@bertinatto
Copy link
Member Author

bertinatto commented Jan 13, 2021

/retest

@huffmanca
Copy link
Contributor

huffmanca commented Jan 13, 2021

/retest

1 similar comment
@jsafrane
Copy link
Contributor

jsafrane commented Jan 14, 2021

/retest

@bertinatto
Copy link
Member Author

bertinatto commented Jan 14, 2021

/refresh

@bertinatto
Copy link
Member Author

bertinatto commented Jan 14, 2021

E0114 13:21:32.061339 94245 test_context.go:485] Failed to setup provider config for "gce": Error building GCE/GKE provider: unexpected response listing zones: googleapi: Error 403: Quota exceeded for quota group 'ListGroup' and limit 'List requests per 100 seconds' of service 'compute.googleapis.com' for consumer 'project_number:1053217076791'., rateLimitExceeded

/test e2e-gcp

@jsafrane
Copy link
Contributor

jsafrane commented Jan 14, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2021
@openshift-merge-robot openshift-merge-robot merged commit a45832b into openshift:master Jan 14, 2021
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 14, 2021

@bertinatto: All pull requests linked via external trackers have merged:

Bugzilla bug 1910459 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1910459: redeploy CSI Controller Deployment when secret changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@jsafrane jsafrane

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bertinatto @openshift-ci-robot @huffmanca @jsafrane @openshift-merge-robot