Bug 1912944: Set proxy env in vsphere-problem-detector, manila and oVirt deployment containers #122

bertinatto · 2021-01-11T20:57:20Z

CC @openshift/storage

openshift-ci-robot · 2021-01-11T20:57:27Z

@bertinatto: This pull request references Bugzilla bug 1912944, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1912944: Set proxy env in Manila CSI driver operator containers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-01-11T20:57:50Z

@bertinatto: This pull request references Bugzilla bug 1912944, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1912944: Set proxy env in Manila CSI driver operator containers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bertinatto · 2021-01-11T20:58:02Z

/hold
this is WIP

jsafrane · 2021-01-12T17:25:32Z

pkg/operator/configobservation/util/util.go

+)
+
+// InjectObservedProxyInDeploymentContainers takes an observed proxy config and returns a patched Deployment with proxy env vars set.
+func InjectObservedProxyInDeploymentContainers(deployment *appsv1.Deployment, opSpec *operatorapi.OperatorSpec, observedConfig []byte, fields ...string) (*appsv1.Deployment, error) {


observedConfig and fields are not used anywhere

bertinatto · 2021-01-12T20:27:56Z

/retest

bertinatto · 2021-01-13T21:29:24Z

/hold cancel
openshift/library-go#976 has been merged.
@openshift/storage PTAL

huffmanca · 2021-01-13T22:22:37Z

/retest

jsafrane · 2021-01-14T09:33:53Z

/retest

jsafrane · 2021-01-14T10:50:15Z

@bertinatto can you please update ovirt CSI operatot deployment too? I noticed it connects to oVirt API to generate the right storage classes: https://github.com/openshift/ovirt-csi-driver-operator/blob/1fda62f9be21bce86f2b0def579e81a4426ea4a0/pkg/operator/storageclass_controller.go#L85

bertinatto · 2021-01-14T12:27:18Z

@bertinatto can you please update ovirt CSI operatot deployment too? I noticed it connects to oVirt API to generate the right storage classes: https://github.com/openshift/ovirt-csi-driver-operator/blob/1fda62f9be21bce86f2b0def579e81a4426ea4a0/pkg/operator/storageclass_controller.go#L85

@jsafrane upated.

bertinatto · 2021-01-14T14:15:26Z

/test e2e-gcp

bertinatto · 2021-01-14T16:10:35Z

/test e2e-gcp

bertinatto · 2021-01-14T20:29:03Z

/test e2e-gcp

bertinatto · 2021-01-14T22:10:13Z

/retest

jsafrane · 2021-01-15T10:31:31Z

/lgtm

bertinatto · 2021-01-15T10:42:09Z

/retest

openshift-bot · 2021-01-15T11:31:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

jsafrane · 2021-01-15T12:03:21Z

/lgtm

openshift-ci-robot · 2021-01-15T12:03:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [bertinatto,jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bertinatto · 2021-01-15T12:18:05Z

level=error msg=Error: googleapi: Error 504: , gatewayTimeout

/test e2e-gcp

openshift-ci-robot · 2021-01-15T14:13:06Z

@bertinatto: All pull requests linked via external trackers have merged:

openshift/cluster-storage-operator#122

Bugzilla bug 1912944 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1912944: Set proxy env in vsphere-problem-detector, manila and oVirt deployment containers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jan 11, 2021

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 11, 2021

openshift-ci-robot requested review from huffmanca and jsafrane January 11, 2021 20:57

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2021

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2021

bertinatto force-pushed the proxy branch 2 times, most recently from ece733a to 1fd93d8 Compare January 12, 2021 14:52

bertinatto changed the title ~~Bug 1912944: Set proxy env in Manila CSI driver operator containers~~ Bug 1912944: Set proxy env in all deployment containers Jan 12, 2021

jsafrane reviewed Jan 12, 2021

View reviewed changes

bertinatto force-pushed the proxy branch from 1fd93d8 to ad4e2a1 Compare January 12, 2021 18:32

bertinatto force-pushed the proxy branch from ad4e2a1 to d9a2564 Compare January 13, 2021 19:09

bertinatto changed the title ~~Bug 1912944: Set proxy env in all deployment containers~~ Bug 1912944: Set proxy env in Manila and vSphere problem detector deployment containers Jan 13, 2021

bertinatto force-pushed the proxy branch from d9a2564 to 6d1e264 Compare January 13, 2021 20:49

bertinatto changed the title ~~Bug 1912944: Set proxy env in Manila and vSphere problem detector deployment containers~~ Bug 1912944: Set proxy env in Manila and vsphere-problem-detector deployment containers Jan 13, 2021

bertinatto force-pushed the proxy branch 4 times, most recently from 0fc9d9e to 7e7515f Compare January 13, 2021 21:02

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2021

bertinatto changed the title ~~Bug 1912944: Set proxy env in Manila and vsphere-problem-detector deployment containers~~ Bug 1912944: Set proxy env in vsphere-problem-detector, manila and oVirt deployment containers Jan 14, 2021

openshift-ci-robot assigned jsafrane Jan 15, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2021

bertinatto added 2 commits January 15, 2021 08:49

Bump library-go (and its dependencies)

d9c8e6b

Add Config Observer controller to watch proxy object

965d762

bertinatto force-pushed the proxy branch from ed5b484 to 0a45723 Compare January 15, 2021 11:50

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2021

bertinatto added 3 commits January 15, 2021 08:52

Set proxy ENV in Manila operator

8d730a6

Set proxy ENV in vSphere problem detector

5eb0f3f

Set proxy ENV in oVirt operator container

f5e252f

bertinatto force-pushed the proxy branch from 0a45723 to f5e252f Compare January 15, 2021 11:52

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2021

openshift-merge-robot merged commit dc9fe11 into openshift:master Jan 15, 2021

Bug 1912944: Set proxy env in vsphere-problem-detector, manila and oVirt deployment containers #122

Bug 1912944: Set proxy env in vsphere-problem-detector, manila and oVirt deployment containers #122

Uh oh!

Conversation

bertinatto commented Jan 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jan 11, 2021

Uh oh!

openshift-ci-robot commented Jan 11, 2021

Uh oh!

bertinatto commented Jan 11, 2021

Uh oh!

jsafrane Jan 12, 2021

Choose a reason for hiding this comment

Uh oh!

bertinatto Jan 12, 2021

Choose a reason for hiding this comment

Uh oh!

bertinatto commented Jan 12, 2021

Uh oh!

bertinatto commented Jan 13, 2021

Uh oh!

huffmanca commented Jan 13, 2021

Uh oh!

jsafrane commented Jan 14, 2021

Uh oh!

jsafrane commented Jan 14, 2021

Uh oh!

bertinatto commented Jan 14, 2021

Uh oh!

bertinatto commented Jan 14, 2021

Uh oh!

bertinatto commented Jan 14, 2021

Uh oh!

bertinatto commented Jan 14, 2021

Uh oh!

bertinatto commented Jan 14, 2021

Uh oh!

jsafrane commented Jan 15, 2021

Uh oh!

bertinatto commented Jan 15, 2021

Uh oh!

openshift-bot commented Jan 15, 2021

Uh oh!

jsafrane commented Jan 15, 2021

Uh oh!

openshift-ci-robot commented Jan 15, 2021

Uh oh!

bertinatto commented Jan 15, 2021

Uh oh!

openshift-ci-robot commented Jan 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bertinatto commented Jan 11, 2021 •

edited

Loading