Skip to content

Bug 1912946: Include proxy ENV in CSI driver#10

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
huffmanca:proxy-env
Jan 14, 2021
Merged

Bug 1912946: Include proxy ENV in CSI driver#10
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
huffmanca:proxy-env

Conversation

@huffmanca
Copy link
Contributor

@huffmanca huffmanca commented Jan 13, 2021

This should address the proxy ENV propagation issues and bumps the versions of openshift/client-go, openshift/library-go, and openshift/api.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 13, 2021
@huffmanca huffmanca changed the title WIP: Bug 1912946: Include proxy ENV in CSI driver Bug 1912946: Include proxy ENV in CSI driver Jan 13, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huffmanca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2021
@openshift-ci-robot
Copy link
Contributor

@huffmanca: This pull request references Bugzilla bug 1912946, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1912946: Include proxy ENV in CSI driver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2021
@openshift-merge-robot openshift-merge-robot merged commit 7edd6a5 into openshift:master Jan 14, 2021
@openshift-ci-robot
Copy link
Contributor

@huffmanca: All pull requests linked via external trackers have merged:

Bugzilla bug 1912946 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1912946: Include proxy ENV in CSI driver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants