csi: add some unit tests to code added recently #981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertinatto
force-pushed
the
add-tests-hooks
branch
2 times, most recently
from
a4eff0d to
c0de5d7
Compare
Contributor
|
Is it still WIP ? Please prefix the PR title if it is. |
bertinatto
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
bertinatto
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
bertinatto
force-pushed
the
add-tests-hooks
branch
2 times, most recently
from
d9dd25f to
ffb587a
Compare
Member
Author
|
/assign @deads2k |
bertinatto
force-pushed
the
add-tests-hooks
branch
3 times, most recently
from
a20b701 to
201a040
Compare
bertinatto
force-pushed
the
add-tests-hooks
branch
from
201a040 to
8174afb
Compare
Contributor
|
/approve I'll leave the decision about coverage to someone closer to storage. |
openshift-ci-robot
added
the
approved
jsafrane
reviewed
Feb 3, 2021
| }, | ||
| }, | ||
| { | ||
| name: "proxy exits, but observed config is different: new config is observed", |
bertinatto
force-pushed
the
add-tests-hooks
branch
from
8174afb to
fb43fef
Compare
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, deads2k, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up PR to add tests to functionalities added in #976.
csi: add unit tests for helper hook functions
These functions were added in #976.
csi: add unit tests for CSI Config Observer Controller
This controller was added in #976.
add fake UpdateOperatorSpec implementation
This is necessary because the ConfigObserver controller updates the spec.
CC @openshift/storage