Skip to content

Conversation

@spadgett
Copy link
Member

No description provided.

honza and others added 30 commits September 5, 2019 09:14
`extensions.k8s.io` will be deprecated in 1.18.
Enable metering proxy for local development
table: do not pass customData as rows
Remove PF3 `<Row>`, `<Col>` components
Use `networking.k8s.io` API group for ingress
`co-break-all` styles weren't being applied to `dd` elements as they
weren't specific enough. `co-break-word` is not needed on `dd` as it's
universally applied. Add `co-select-to-copy` for some fields.
- improve responsive support
- on thelink block hover only title gets underline
- make element consistent on table and details views buy removing box around logo
https://jira.coreos.com/browse/CONSOLE-1761
@spadgett
Copy link
Member Author

error /go/src/github.com/openshift/console/frontend/node_modules/chromedriver: Command failed.

/retest

@spadgett
Copy link
Member Author

/retest

@spadgett
Copy link
Member Author

level=error msg=""aws" produced an unexpected new value for was present, but now absent."

/retest

@mareklibra
Copy link
Contributor

/retest

@yaacov
Copy link
Member

yaacov commented Sep 24, 2019

/test e2e-aws

1 similar comment
@rawagner
Copy link
Contributor

/test e2e-aws

@rhamilto
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member Author

/retest

2 similar comments
@spadgett
Copy link
Member Author

/retest

@spadgett
Copy link
Member Author

/retest

@spadgett
Copy link
Member Author

e2e-aws failing due to https://bugzilla.redhat.com/show_bug.cgi?id=1755000

@spadgett
Copy link
Member Author

/retest

@spadgett
Copy link
Member Author

/retest

1 similar comment
@spadgett
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit feabd61 into openshift:master Sep 25, 2019
@spadgett spadgett deleted the 4.3-features branch September 25, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/kubevirt Related to kubevirt-plugin component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/noobaa Related to noobaa-storage-plugin component/olm Related to OLM component/sdk Related to console-plugin-sdk component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. queue/blocks-others size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.