dashboard: Enhance DetailsCard for new fields #2586

mareklibra · 2019-09-04T09:48:29Z

Added:

Cluster API address
Update channel

Changed:

Cluster ID contains link to Cluster Manager
OpenShift Cluster Version can pop-up a modal dialog to update cluster

Generic changes:

Textual dashboard detail items are rendered with the "co-select-to-copy" to simplify copy&paste user action

Depends on:

Added a external link to noobaa details card #2520 (DetailItem changes)

mareklibra · 2019-09-04T09:51:31Z

cc @andybraren , @rawagner

rawagner · 2019-09-04T10:00:19Z

You should rebase on top of #2520 which changes DetailsItem api.

cloudbehl · 2019-09-04T10:28:15Z

@mareklibra @rawagner I think update channel is something that might also be required for the Storage dashboard also.

@shirimordechay @yuvalgalanti ^^

mareklibra · 2019-09-04T10:49:18Z

Rebased on top of #2520

rawagner · 2019-09-04T10:52:37Z

frontend/public/components/dashboards-page/overview-dashboard/details-card.tsx

can you remove key prop for all Items ? its actually not needed

rawagner · 2019-09-04T10:53:16Z

frontend/public/components/dashboards-page/overview-dashboard/details-card.tsx

shouldnt it be error={!!infrastructureError || !getInfrastructureAPIURL(infrastructureData)} ?

rawagner · 2019-09-04T10:54:35Z

frontend/public/components/dashboards-page/overview-dashboard/details-card.tsx

I'd add || !getCVChannel(clusterVersionData)

after adding it, can you extract the getCVChannel(clusterVersionData) so we call it just once for error and children ?

andybraren · 2019-09-04T14:49:58Z

Yay! Thank you @mareklibra! 😄

OpenShift Cluster Version is newly a link to Cluster Settings page

Good idea! We have some ideas for 4.3 around initiating upgrades from the dashboard that may affect this, but if this PR is for 4.2 this sounds great. 👍

mareklibra · 2019-09-05T12:20:40Z

Rebased as #2520 is merged now

mareklibra · 2019-09-06T06:51:51Z

rebased

mareklibra · 2019-09-19T11:35:17Z

Rebased to master-4.3.
@rawagner, can you please have a look?

rawagner · 2019-09-21T11:56:01Z

/lgtm

mareklibra · 2019-09-23T08:02:43Z

/assign @kyoto

kyoto · 2019-09-24T01:55:10Z

/approve

openshift-bot · 2019-09-24T03:45:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-09-24T05:42:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

andybraren · 2019-10-08T03:30:56Z

@andybraren I'm curious about the decision to say "update available" rather than simply saying "update" when an update is available. "Update" (or "update cluster") is an action, whereas "update available" is just informative. Should that be a call to action?

Good call @ncameronbritt, thank you! The nearby Status card's message will include a call-to-action to "Update", so reusing the exact same CTA here makes sense, especially since they both lead to the same modal.

Sorry for so many last minute tweaks @mareklibra 🙂 - could "Update available" be changed to just "Update"?

mareklibra · 2019-10-08T06:03:40Z

@andybraren , @ncameronbritt , the action is renamed now.

mareklibra · 2019-10-08T07:06:04Z

/retest

mareklibra · 2019-10-09T11:57:44Z

Rebased

andybraren

Thank you @mareklibra!

mareklibra · 2019-10-10T07:43:35Z

@spadgett , can you please have a look?

vojtechszocs · 2019-10-15T17:18:59Z

frontend/packages/console-shared/src/components/dashboard/details-card/DetailItem.tsx

Nit: valueClassName

+1 to valueClassName

vojtechszocs · 2019-10-15T17:27:32Z

LGTM (with a small nit) #2586 (review)

Not giving lgtm label yet since @spadgett raised some comments as well.

spadgett

Thanks, this looks cleaner to me

spadgett · 2019-10-15T17:27:16Z

frontend/public/components/dashboard/dashboards-page/overview-dashboard/details-card.tsx

Make this a link instead of a button since it's a link :)

spadgett · 2019-10-15T17:27:52Z

frontend/packages/console-shared/src/components/dashboard/details-card/DetailItem.tsx

+1 to valueClassName

mareklibra · 2019-10-18T10:27:24Z

@spadgett , review comments addressed, can you please have a look?

vojtechszocs · 2019-10-21T17:45:56Z

LGTM on recent change diff.

mareklibra · 2019-10-22T07:22:07Z

@spadgett , wdyt, please?

Added: - Cluster API address - Update channel Changed: - Cluster ID contains link to Cluster Manager - OpenShift Cluster Version can pop-up a modal dialog to update cluster Generic changes: - Textual dashboard detail items are rendered with the "co-select-to-copy" to simplify copy&paste user action

mareklibra · 2019-10-29T10:46:36Z

Rebased

mareklibra · 2019-10-29T13:15:10Z

/hold cancel
#2817 is merged

rawagner · 2019-10-29T13:46:30Z

/lgtm

spadgett

/approve
/lgtm

openshift-ci-robot · 2019-10-29T13:55:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andybraren, kyoto, mareklibra, rawagner, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [kyoto,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vojtechszocs · 2019-10-29T19:36:48Z

/retest

openshift-bot · 2019-10-30T02:41:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-10-30T06:09:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-10-30T07:14:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-10-30T08:06:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

jelkosz · 2019-10-30T13:20:47Z

/retest

openshift-bot · 2019-10-30T15:02:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

spadgett · 2019-10-30T17:44:44Z

Last test flake should be fixed by #3158

/retest

openshift-ci-robot requested review from alecmerdler and rhamilto September 4, 2019 09:48

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/core Related to console core functionality component/shared Related to console-shared labels Sep 4, 2019

openshift-ci-robot added component/ceph Related to ceph-storage-plugin component/noobaa Related to noobaa-storage-plugin size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 4, 2019

rawagner suggested changes Sep 4, 2019

View reviewed changes

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 5, 2019

mareklibra changed the base branch from master to master-4.3 September 19, 2019 11:34

openshift-ci-robot assigned rawagner Sep 21, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2019

openshift-ci-robot assigned kyoto Sep 23, 2019

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2019

andybraren approved these changes Oct 9, 2019

View reviewed changes

vojtechszocs suggested changes Oct 15, 2019

View reviewed changes

spadgett reviewed Oct 15, 2019

View reviewed changes

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2019

spadgett approved these changes Oct 29, 2019

View reviewed changes

openshift-ci-robot assigned spadgett Oct 29, 2019

openshift-merge-robot merged commit b7ec208 into openshift:master Oct 30, 2019

dashboard: Enhance DetailsCard for new fields #2586

dashboard: Enhance DetailsCard for new fields #2586

Uh oh!

Conversation

mareklibra commented Sep 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mareklibra commented Sep 4, 2019

Uh oh!

rawagner commented Sep 4, 2019

Uh oh!

cloudbehl commented Sep 4, 2019

Uh oh!

mareklibra commented Sep 4, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andybraren commented Sep 4, 2019

Uh oh!

mareklibra commented Sep 5, 2019

Uh oh!

mareklibra commented Sep 6, 2019

Uh oh!

mareklibra commented Sep 19, 2019

Uh oh!

rawagner commented Sep 21, 2019

Uh oh!

mareklibra commented Sep 23, 2019

Uh oh!

kyoto commented Sep 24, 2019

Uh oh!

openshift-bot commented Sep 24, 2019

Uh oh!

openshift-bot commented Sep 24, 2019

Uh oh!

andybraren commented Oct 8, 2019

Uh oh!

mareklibra commented Oct 8, 2019

Uh oh!

mareklibra commented Oct 8, 2019

Uh oh!

mareklibra commented Oct 9, 2019

Uh oh!

andybraren left a comment

Choose a reason for hiding this comment

Uh oh!

mareklibra commented Oct 10, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vojtechszocs commented Oct 15, 2019

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mareklibra commented Oct 18, 2019

Uh oh!

vojtechszocs commented Oct 21, 2019

Uh oh!

mareklibra commented Oct 22, 2019

mareklibra commented Sep 4, 2019 •

edited

Loading