Skip to content

Add access review check for overview/topology start build action #2816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 25, 2019
Merged

Add access review check for overview/topology start build action #2816

openshift-merge-robot merged 1 commit into from
Sep 25, 2019

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Sep 23, 2019

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 23, 2019
@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Sep 23, 2019
@spadgett
Copy link
Member Author

spadgett commented Sep 23, 2019

cc @serenamarie125

@serenamarie125
Copy link
Contributor

serenamarie125 commented Sep 23, 2019

thanks for the quick turn around @spadgett

rhamilto
rhamilto reviewed Sep 23, 2019
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 23, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member Author

spadgett commented Sep 23, 2019

/hold
for #2817

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2019
@spadgett spadgett changed the base branch from master-4.3 to master September 25, 2019 18:38
@spadgett
Copy link
Member Author

spadgett commented Sep 25, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2019
@spadgett spadgett added this to the v4.3 milestone Sep 25, 2019
@openshift-merge-robot openshift-merge-robot merged commit d3af747 into openshift:master Sep 25, 2019
@spadgett spadgett deleted the start-build-access branch September 25, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamilto rhamilto rhamilto left review comments

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@rhamilto rhamilto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@spadgett @serenamarie125 @openshift-ci-robot @openshift-bot @rhamilto @openshift-merge-robot