Skip to content

Change font to Red Hat #2668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 17, 2019
Merged

Change font to Red Hat #2668

openshift-merge-robot merged 1 commit into from
Sep 17, 2019

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Sep 10, 2019 •
edited
Loading

localhost_9000_dashboards (2)
localhost_9000_dashboards (4)
localhost_9000_dashboards (5)

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 10, 2019
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/dev-console Related to dev-console component/monitoring Related to monitoring component/olm Related to OLM labels Sep 10, 2019
@rhamilto rhamilto force-pushed the redhat-font branch 2 times, most recently from 50e7c04 to 02a7afb Compare September 10, 2019 20:49
@spadgett spadgett added this to the v4.3 milestone Sep 11, 2019
@spadgett spadgett mentioned this pull request Sep 11, 2019
Merged
@rhamilto rhamilto force-pushed the redhat-font branch 2 times, most recently from 89a3917 to a52c690 Compare September 11, 2019 17:31
@rhamilto
Copy link
Member Author

rhamilto commented Sep 13, 2019

/retest

@spadgett spadgett changed the base branch from master to master-4.3 September 17, 2019 13:14
@spadgett
Copy link
Member

spadgett commented Sep 17, 2019

@rhamilto is this ready for review or still more to do?

@rhamilto rhamilto changed the title [WIP] Change font to Red Hat Change font to Red Hat Sep 17, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2019
@rhamilto
Copy link
Member Author

rhamilto commented Sep 17, 2019

@rhamilto is this ready for review or still more to do?

Ready now. We may want to have a visual designer review. I made educated guesses about heading styles. There is not good documentation in PatternFly for them.

rhamilto
rhamilto commented Sep 17, 2019
View reviewed changes
frontend/public/style/_vars.scss Outdated
Copy link
Member Author

@rhamilto rhamilto Sep 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be changed after #2710 merges.

Copy link
Member Author

@rhamilto rhamilto Sep 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. @spadgett, please re-tag.

spadgett
spadgett approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! We can address the heading styles as a follow on if needed. I'd like to get this in early so we have time to shake out any problems.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2019
@rhamilto
Copy link
Member Author

rhamilto commented Sep 17, 2019

/retest

@janwright73
Copy link

janwright73 commented Sep 17, 2019

@rhamilto @spadgett - how best to get a visual designer, Mary S, connected to this effort to start the review (and help identify documentation improvements)?

@rhamilto
Copy link
Member Author

rhamilto commented Sep 17, 2019

/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2019
@spadgett
Copy link
Member

spadgett commented Sep 17, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2019
@rhamilto
Copy link
Member Author

rhamilto commented Sep 17, 2019

/retest

@spadgett
Copy link
Member

spadgett commented Sep 17, 2019

/lgtm

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 09bda4a into openshift:master-4.3 Sep 17, 2019
@rhamilto rhamilto deleted the redhat-font branch September 18, 2019 12:43
@maryshak1996
Copy link

maryshak1996 commented Sep 18, 2019

@janwright73 not sure why tagging my name doesn't work, but I've got this on my radar and will be starting a review of typography this week and next :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@abhinandan13jan abhinandan13jan Awaiting requested review from abhinandan13jan

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/monitoring Related to monitoring component/olm Related to OLM lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@rhamilto @spadgett @janwright73 @openshift-ci-robot @maryshak1996 @openshift-merge-robot