Skip to content

table: do not pass customData as rows #2701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 17, 2019
Merged

table: do not pass customData as rows #2701

openshift-merge-robot merged 1 commit into from
Sep 17, 2019

Conversation

@atiratree
Copy link
Member

@atiratree atiratree commented Sep 12, 2019

This change was introduced by #2359, but is not used in the end.

It breaks (react warnings) original usage of this prop which is passing customData down to the rows.

Another prop should be introduced in the future if requirement for this use case arises.

cc @priley86

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. component/core Related to console core functionality labels Sep 12, 2019
@atiratree
Copy link
Member Author

atiratree commented Sep 12, 2019

/test e2e-aws-console

@spadgett
Copy link
Member

spadgett commented Sep 17, 2019

If this is only a prop warning, let's target to 4.3.

@spadgett spadgett changed the base branch from master to master-4.3 September 17, 2019 13:43
@spadgett spadgett added this to the v4.3 milestone Sep 17, 2019
spadgett
spadgett approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, suomiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2019
@spadgett
Copy link
Member

spadgett commented Sep 17, 2019

/kind cleanup

@openshift-ci-robot openshift-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 17, 2019
@spadgett
Copy link
Member

spadgett commented Sep 17, 2019

/retest

1 similar comment
@atiratree
Copy link
Member Author

atiratree commented Sep 17, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit a0a6e40 into openshift:master-4.3 Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@atiratree @spadgett @openshift-ci-robot @openshift-merge-robot @suomiy