Skip to content

Migrate <HintBlock> from PF3 #2718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 17, 2019
Merged

Migrate <HintBlock> from PF3 #2718

openshift-merge-robot merged 1 commit into from
Sep 17, 2019

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Sep 13, 2019 •
edited
Loading

Resolves https://jira.coreos.com/browse/CONSOLE-1759

<HintBlock> doesn't exist in PF4, is pretty specific as far as components go, and contains PF3-specific styling that cannot be changed, so it makes the most sense to migrate the component over to the console code base directly. Note the migrated version does not obtain feature parity with the PF3 version it replaces as there was no need to migrate functionality that was not in use.

Screen Shot 2019-09-13 at 3 25 25 PM

Screen Shot 2019-09-16 at 10 30 39 AM
Screen Shot 2019-09-16 at 10 32 54 AM
Screen Shot 2019-09-16 at 11 32 55 AM

@rhamilto rhamilto added this to the v4.3 milestone Sep 13, 2019
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/dev-console Related to dev-console component/olm Related to OLM size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 13, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2019
@spadgett
Copy link
Member

spadgett commented Sep 13, 2019

/hold
for 4.3

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2019
@spadgett
Copy link
Member

spadgett commented Sep 13, 2019

This looks pretty similar to StartGuide. Can that be used here?

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 16, 2019
spadgett
spadgett reviewed Sep 16, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, but I noticed some out-of-date help for Chargeback. We should fix that in a separate PR for 4.2.

cc @dtaylor113 @chancez

@spadgett
Copy link
Member

spadgett commented Sep 16, 2019

Actually I don't think this hint block will ever display for Chargeback since we hide the nav item when the flag isn't set. We can probably just remove it.

spadgett
spadgett reviewed Sep 16, 2019
View reviewed changes
@rhamilto rhamilto force-pushed the pf4-hintBlock branch 2 times, most recently from e9cca3a to 7d6a0fa Compare September 16, 2019 20:28
@spadgett spadgett changed the base branch from master to master-4.3 September 17, 2019 13:06
spadgett
spadgett reviewed Sep 17, 2019
View reviewed changes
frontend/public/components/chargeback.tsx Outdated
Copy link
Member

@spadgett spadgett Sep 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can remove this check as well

Copy link
Member Author

@rhamilto rhamilto Sep 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@spadgett
Copy link
Member

spadgett commented Sep 17, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2019
@rhamilto
Copy link
Member Author

rhamilto commented Sep 17, 2019

/retest

@spadgett spadgett added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 17, 2019
@rhamilto
Copy link
Member Author

rhamilto commented Sep 17, 2019

/retest

spadgett
spadgett reviewed Sep 17, 2019
View reviewed changes
frontend/public/components/utils/hint-block.tsx Outdated
Copy link
Member

@spadgett spadgett Sep 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we consider making this children instead? I know this was the original API from Patternfly, but I don't see a reason this needs to be a special prop.

Copy link
Member Author

@rhamilto rhamilto Sep 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we can. Was going for minimal changes...

Copy link
Member Author

@rhamilto rhamilto Sep 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. PTAL @spadgett

spadgett
spadgett approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0a62374 into openshift:master-4.3 Sep 17, 2019
@rhamilto rhamilto deleted the pf4-hintBlock branch September 18, 2019 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@nemesis09 nemesis09 Awaiting requested review from nemesis09

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/olm Related to OLM kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

4 participants

@rhamilto @spadgett @openshift-ci-robot @openshift-merge-robot