Skip to content

STOR-1291: Add migration status#107

Closed
gnufied wants to merge 2 commits intoopenshift:masterfrom
gnufied:add-migration-status
Closed

STOR-1291: Add migration status#107
gnufied wants to merge 2 commits intoopenshift:masterfrom
gnufied:add-migration-status

Conversation

@gnufied
Copy link
Member

@gnufied gnufied commented Apr 6, 2023

Add code for checking migration status

@gnufied gnufied changed the title Add migration status {WIP} Add migration status Apr 6, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2023
@openshift-ci openshift-ci bot requested review from bertinatto and tsmetana April 6, 2023 20:33
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 6, 2023

@gnufied: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere a1cf7fb link true /test e2e-vsphere

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dobsonj
Copy link
Member

dobsonj commented Apr 11, 2023

This seems reasonable I think

@gnufied gnufied changed the title {WIP} Add migration status STOR-1291: Add migration status Apr 12, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 12, 2023 •
edited by openshift-ci bot
Loading

@gnufied: This pull request references STOR-1291 which is a valid jira issue.

Details

In response to this:

Add code for checking migration status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 12, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2023
@dobsonj
Copy link
Member

dobsonj commented Apr 13, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023
@gnufied
Copy link
Member Author

gnufied commented Apr 13, 2023

Lets hold for other migration changes to merge.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2023
@dobsonj dobsonj mentioned this pull request Apr 14, 2023
Merged
@gnufied
Copy link
Member Author

gnufied commented Apr 14, 2023

I have tested this PR in a real cluster with upgrades and it works as expected.

@gnufied
Copy link
Member Author

gnufied commented Apr 14, 2023

Since we only need this in 4.13 I am going to close this in favour of #108

@gnufied gnufied closed this Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@tsmetana tsmetana Awaiting requested review from tsmetana

Assignees

@dobsonj dobsonj

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gnufied @dobsonj @openshift-ci-robot