make/targets/openshift/yaml-patch: fix missing repository#58
Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom Dec 13, 2021
Merged
make/targets/openshift/yaml-patch: fix missing repository#58openshift-merge-robot merged 2 commits intoopenshift:masterfrom
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Conversation
yaml-patch seems to have disappeared. This fixes it by moving to the pivotal repository.
Contributor
|
/lgtm worth a proof PR ? |
openshift-ci
Bot
added
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: s-urbaniak, soltysh, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Contributor
Author
indeed, i proofed it locally, let me open one against cert-manager-operator (the victim) |
Contributor
|
@s-urbaniak: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
Author
|
proof PR: openshift/api#1083 |
Contributor
|
/cancel hold |
|
/hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
This was referenced Dec 14, 2021
Closed
florkbr
added a commit
to florkbr/console-operator
that referenced
this pull request
Dec 14, 2021
This will need to be ported to our master-multi-cluster branch See: openshift/build-machinery-go#58 CC @TheRealJon @spadgett
eggfoobar
added a commit
to eggfoobar/console-operator
that referenced
this pull request
Dec 14, 2021
updated to using latest library-go updated build images to use go 1.17 updated method signatures for library-go methods where context is passed in update test to work with go 1.17 crypto message change Signed-off-by: ehila <ehila@redhat.com> fix: updated build-machinery to fix yaml-patch verify updated build-machinery - more info: openshift/build-machinery-go#58 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/console-operator
that referenced
this pull request
Dec 14, 2021
updated to using latest library-go updated build images to use go 1.17 updated method signatures for library-go methods where context is passed in update test to work with go 1.17 crypto message change Signed-off-by: ehila <ehila@redhat.com> fix: updated build-machinery to fix yaml-patch verify updated build-machinery - more info: openshift/build-machinery-go#58 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/cluster-image-registry-operator
that referenced
this pull request
Dec 14, 2021
fetched latest library-go and vendored dep updated handlers to use updated sctruct names updated okd builder image to use go 1.17 Signed-off-by: ehila <ehila@redhat.com> fix: updated build-machinery to fix yaml-patch verify updated build-machinery - more info: openshift/build-machinery-go#58 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/cluster-image-registry-operator
that referenced
this pull request
Dec 15, 2021
fetched latest library-go and vendored dep updated handlers to use updated sctruct names updated okd builder image to use go 1.17 Signed-off-by: ehila <ehila@redhat.com> fix: updated build-machinery to fix yaml-patch verify updated build-machinery - more info: openshift/build-machinery-go#58 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/cluster-config-operator
that referenced
this pull request
Dec 15, 2021
updated library go to latest Signed-off-by: ehila <ehila@redhat.com> fix: updated build-machinery to fix yaml-patch verify updated build-machinery - more info: openshift/build-machinery-go#58 Signed-off-by: ehila <ehila@redhat.com> feat: updated logs to explicitly add flags logs requires explict calls to add flags in latest version Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/cluster-config-operator
that referenced
this pull request
Dec 21, 2021
updated library go to latest Signed-off-by: ehila <ehila@redhat.com> fix: updated build-machinery to fix yaml-patch verify updated build-machinery - more info: openshift/build-machinery-go#58 Signed-off-by: ehila <ehila@redhat.com> feat: updated logs to explicitly add flags logs requires explict calls to add flags in latest version Signed-off-by: ehila <ehila@redhat.com>
Contributor
|
/cherry-pick release-4.9 |
|
@jsafrane: new pull request created: #59 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This was referenced Dec 21, 2021
eggfoobar
added a commit
to eggfoobar/cluster-image-registry-operator
that referenced
this pull request
Dec 24, 2021
fetched latest library-go and vendored dep updated handlers to use updated sctruct names updated okd builder image to use go 1.17 Signed-off-by: ehila <ehila@redhat.com> fix: updated build-machinery to fix yaml-patch verify updated build-machinery - more info: openshift/build-machinery-go#58 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/cluster-image-registry-operator
that referenced
this pull request
Jan 7, 2022
fetched latest library-go and vendored dep updated handlers to use updated sctruct names updated okd builder image to use go 1.17 Signed-off-by: ehila <ehila@redhat.com> fix: updated build-machinery to fix yaml-patch verify updated build-machinery - more info: openshift/build-machinery-go#58 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/cluster-config-operator
that referenced
this pull request
Jan 10, 2022
updated library go to latest Signed-off-by: ehila <ehila@redhat.com> fix: updated build-machinery to fix yaml-patch verify updated build-machinery - more info: openshift/build-machinery-go#58 Signed-off-by: ehila <ehila@redhat.com> feat: updated logs to explicitly add flags logs requires explict calls to add flags in latest version Signed-off-by: ehila <ehila@redhat.com> bump: library-go updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/cluster-image-registry-operator
that referenced
this pull request
Jan 25, 2022
fetched latest library-go and vendored dep updated handlers to use updated sctruct names updated okd builder image to use go 1.17 Signed-off-by: ehila <ehila@redhat.com> fix: updated build-machinery to fix yaml-patch verify updated build-machinery - more info: openshift/build-machinery-go#58 Signed-off-by: ehila <ehila@redhat.com> fix: pull in latest library-go pull in to grab fix described here openshift/library-go#1272 Signed-off-by: ehila <ehila@redhat.com> bump: library-go updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @sttts @soltysh