Ensure that required is always fixed up by ApplySecret

[jerpeter1]

This is to fix TestEnsureNodeKubeconfigs in cluster-kube-apiserver's unit tests (I'm not sure if the test being broken is actually important or not, but we can re-address that later)

[jerpeter1]

/assign @deads2k

[deads2k]

existing, err := 
if err != nil && !apierrors.IsNotFound(err){
    return nil, false, err
}
if cache.SafeToSkipApply(requiredInput, existing) {
	return existing, false, nil
}

// do the required deep copy and string data stuff

if apierrors.IsNotFound(err) {
		requiredCopy := requiredInput.DeepCopy()
		actual, err := client.Secrets(requiredCopy.Namespace).
			Create(ctx, resourcemerge.WithCleanLabelsAndAnnotations(requiredCopy).(*corev1.Secret), metav1.CreateOptions{})
		reportCreateEvent(recorder, requiredCopy, err)
		cache.UpdateCachedResourceMetadata(requiredInput, actual)
		return actual, true, err
	}

// make sure all UpdateCachedResourceMetadata use requiredInput and not required

and you keep your "skip deep copy" behavior, right?

[jerpeter1]

I just tested your suggestion, but I had to make a small change to get the unit tests to pass (requiredCopy := required.DeepCopy() instead of requiredCopy := requiredInput.DeepCopy()

[deads2k]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, jerpeter1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/operator/OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jerpeter1: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.