CFE-72: make infrastructure resource tags updatable by Elbehery · Pull Request #685 · openshift/cluster-ingress-operator

Elbehery · 2021-12-13T15:56:23Z

This PR adds a watch for Infrastructure type to update AWS tags when changed

Elbehery · 2021-12-13T15:56:44Z

/assign @arjunrn
/assign @lmzuccarelli

Elbehery · 2021-12-13T16:09:19Z

/retest

Elbehery · 2021-12-13T16:20:42Z

/retest

Elbehery · 2021-12-14T09:18:21Z

This error exists on the master branch, not from my commit

@arjunrn
@lmzuccarelli
@Connect2naga

lmzuccarelli · 2021-12-14T09:37:48Z

 	if err := c.Watch(&source.Kind{Type: &configv1.Ingress{}}, handler.EnqueueRequestsFromMapFunc(reconciler.ingressConfigToIngressController)); err != nil {
 		return nil, err
 	}
+	if err := c.Watch(&source.Kind{Type: &configv1.Infrastructure{}}, handler.EnqueueRequestsFromMapFunc(reconciler.ingressConfigToIngressController)); err != nil {


Nice simple change

lmzuccarelli · 2021-12-14T10:15:36Z

@Elbehery Can you check why the verify job is failing.

Elbehery · 2021-12-14T10:41:58Z

@Elbehery Can you check why the verify job is failing.

there is a fix here openshift/build-machinery-go#58 .. I will try to bump in the machinary version in this repo

Elbehery · 2021-12-14T11:54:38Z

@lmzuccarelli added this PR #688 to fix the issue

openshift-ci · 2021-12-14T12:04:17Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Elbehery
To complete the pull request process, please ask for approval from lmzuccarelli after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Miciah · 2021-12-14T16:43:51Z

 	awsLBHealthCheckIntervalAnnotation,
 	GCPGlobalAccessAnnotation,
 	localWithFallbackAnnotation,
+	awsLBAdditionalResourceTags,


This will cause the operator to override user changes to the annotation. @frobware, is there a reason the operator didn't manage this annotation before? Is documenting the change sufficient, or do we need to backport some logic to set Upgradeable=False if the user has set an annotation that doesn't match the tags specified in the infrastructure config?

is there a reason the operator didn't manage this annotation before?

It's not clear to me whether this should have been specified previously or is/was a glaring omission; that's perhaps not terribly helpful but if we go ahead with this change then we should also go with the additional logic (and backports) for smooth upgrades (IMO).

@Miciah @frobware thanks a lot for your review

The target of this PR is a watch the AWS resource tags on the infrastructure crd and update the tags accordingly.
Would this change be sufficient for this purpose ?

cc @arjunrn @lmzuccarelli

Elbehery · 2021-12-14T18:52:58Z

/retest

Elbehery · 2021-12-23T08:32:34Z

/retest

Elbehery · 2021-12-23T10:46:46Z

/retest

Elbehery · 2021-12-23T12:58:13Z

/retest

openshift-ci · 2021-12-23T14:24:13Z

@Elbehery: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-01-23T02:14:39Z

@Elbehery: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2022-04-23T06:03:45Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2022-05-23T06:24:44Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2022-06-22T06:47:34Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2022-06-22T06:48:08Z

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci Bot assigned arjunrn and lmzuccarelli Dec 13, 2021

openshift-ci Bot requested review from frobware and lmzuccarelli December 13, 2021 15:56

lmzuccarelli reviewed Dec 14, 2021

View reviewed changes

Elbehery force-pushed the make-aws-tags-updatable branch 3 times, most recently from d3988aa to 77c016c Compare December 14, 2021 16:35

Miciah reviewed Dec 14, 2021

View reviewed changes

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2021

CFE-72: make infrastructure resource tags updatable

1270adc

Elbehery force-pushed the make-aws-tags-updatable branch from 77c016c to 1270adc Compare December 23, 2021 08:40

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2021

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2022

openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 23, 2022

openshift-ci Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 23, 2022

openshift-ci Bot closed this Jun 22, 2022

Conversation

Elbehery commented Dec 13, 2021

Uh oh!

Elbehery commented Dec 13, 2021

Uh oh!

Elbehery commented Dec 13, 2021

Uh oh!

Elbehery commented Dec 13, 2021

Uh oh!

Elbehery commented Dec 14, 2021

Uh oh!

lmzuccarelli Dec 14, 2021

Choose a reason for hiding this comment

Uh oh!

lmzuccarelli commented Dec 14, 2021

Uh oh!

Elbehery commented Dec 14, 2021

Uh oh!

Elbehery commented Dec 14, 2021

Uh oh!

openshift-ci Bot commented Dec 14, 2021

Uh oh!

Miciah Dec 14, 2021

Choose a reason for hiding this comment

Uh oh!

frobware Dec 14, 2021

Choose a reason for hiding this comment

Uh oh!

Elbehery Dec 23, 2021

Choose a reason for hiding this comment

Uh oh!

Elbehery commented Dec 14, 2021

Uh oh!

Elbehery commented Dec 23, 2021

Uh oh!

Elbehery commented Dec 23, 2021

Uh oh!

Elbehery commented Dec 23, 2021

Uh oh!

openshift-ci Bot commented Dec 23, 2021

Uh oh!

openshift-ci Bot commented Jan 23, 2022

Uh oh!

openshift-bot commented Apr 23, 2022

Uh oh!

openshift-bot commented May 23, 2022

Uh oh!

openshift-bot commented Jun 22, 2022

Uh oh!

openshift-ci Bot commented Jun 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants