Add nil checks to resource cache#1273
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Dec 20, 2021
Merged
Conversation
ApplSecret is a caching client so sometimes will return a nil from a GET, which causes the embedded ObjectMeta to be nil.
Member
Author
|
/assign @deads2k |
Contributor
|
golang will make an old man out of me. /lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, jerpeter1 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Member
Author
|
/retest-required |
Member
Author
|
/test unit |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Member
Author
|
/test unit |
Contributor
|
@jerpeter1: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
eggfoobar
added a commit
to eggfoobar/cluster-storage-operator
that referenced
this pull request
Dec 20, 2021
updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/cluster-version-operator
that referenced
this pull request
Dec 20, 2021
updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/cluster-csi-snapshot-controller-operator
that referenced
this pull request
Dec 20, 2021
updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/local-storage-operator
that referenced
this pull request
Dec 20, 2021
updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/performance-addon-operators
that referenced
this pull request
Dec 20, 2021
updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/performance-addon-operators
that referenced
this pull request
Dec 20, 2021
updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/cluster-policy-controller
that referenced
this pull request
Dec 20, 2021
updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/cluster-openshift-controller-manager-operator
that referenced
this pull request
Dec 20, 2021
updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/cluster-openshift-apiserver-operator
that referenced
this pull request
Dec 20, 2021
updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/cluster-config-operator
that referenced
this pull request
Dec 20, 2021
updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/console-operator
that referenced
this pull request
Dec 20, 2021
updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/cluster-image-registry-operator
that referenced
this pull request
Dec 21, 2021
updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/cluster-config-operator
that referenced
this pull request
Dec 21, 2021
updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/cluster-autoscaler-operator
that referenced
this pull request
Dec 21, 2021
updated to include missed rbac permission for infrastructure resource updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/cluster-image-registry-operator
that referenced
this pull request
Dec 24, 2021
updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/cluster-image-registry-operator
that referenced
this pull request
Dec 24, 2021
pull in to grab fix described here openshift/library-go#1272 Signed-off-by: ehila <ehila@redhat.com> bump: library-go updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/cluster-csi-snapshot-controller-operator
that referenced
this pull request
Jan 6, 2022
updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/cluster-csi-snapshot-controller-operator
that referenced
this pull request
Jan 6, 2022
updated method scalls with new signatures removed passing next generation to ApplyValidationWebhookConfiguration updated to use explicit call to bind log flags to cli commandline Signed-off-by: ehila <ehila@redhat.com> upkeep: removed unused code and small clean up Signed-off-by: ehila <ehila@redhat.com> fix: pull in latest library-go pull in to grab fix described here openshift/library-go#1272 Signed-off-by: ehila <ehila@redhat.com> bump: library-go updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/cluster-image-registry-operator
that referenced
this pull request
Jan 7, 2022
pull in to grab fix described here openshift/library-go#1272 Signed-off-by: ehila <ehila@redhat.com> bump: library-go updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/cluster-config-operator
that referenced
this pull request
Jan 10, 2022
updated library go to latest Signed-off-by: ehila <ehila@redhat.com> fix: updated build-machinery to fix yaml-patch verify updated build-machinery - more info: openshift/build-machinery-go#58 Signed-off-by: ehila <ehila@redhat.com> feat: updated logs to explicitly add flags logs requires explict calls to add flags in latest version Signed-off-by: ehila <ehila@redhat.com> bump: library-go updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
added a commit
to eggfoobar/cluster-image-registry-operator
that referenced
this pull request
Jan 25, 2022
fetched latest library-go and vendored dep updated handlers to use updated sctruct names updated okd builder image to use go 1.17 Signed-off-by: ehila <ehila@redhat.com> fix: updated build-machinery to fix yaml-patch verify updated build-machinery - more info: openshift/build-machinery-go#58 Signed-off-by: ehila <ehila@redhat.com> fix: pull in latest library-go pull in to grab fix described here openshift/library-go#1272 Signed-off-by: ehila <ehila@redhat.com> bump: library-go updated library-go to latest for fix in pr openshift/library-go#1273 Signed-off-by: ehila <ehila@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ApplSecret is a caching client so sometimes will return a nil from a GET, which causes
the embedded ObjectMeta to be nil.