Skip to content

use pivotal-cf/yaml-patch to replace krishicks/yaml-patch#57

Closed
zhujian7 wants to merge 1 commit intoopenshift:masterfrom
zhujian7:yaml-patch
Closed

use pivotal-cf/yaml-patch to replace krishicks/yaml-patch#57
zhujian7 wants to merge 1 commit intoopenshift:masterfrom
zhujian7:yaml-patch

Conversation

@zhujian7
Copy link
Copy Markdown
Contributor

@zhujian7 zhujian7 commented Dec 13, 2021

Fix #56

Not sure if pivotal-cf/yaml-patch is a good alternative option for krishicks/yaml-patch, but I found most commits' author of pivotal-cf/yaml-patch is krishicks.

Signed-off-by: zhujian jiazhu@redhat.com

Signed-off-by: zhujian <jiazhu@redhat.com>
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 13, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhujian7
To complete the pull request process, please assign mfojtik after the PR has been reviewed.
You can assign the PR to them by writing /assign @mfojtik in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from 2uasimojo and mfojtik December 13, 2021 07:33
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 13, 2021

@zhujian7: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhujian7
Copy link
Copy Markdown
Contributor Author

/assign @mfojtik

@zhujian7
Copy link
Copy Markdown
Contributor Author

/assign @2uasimojo

@soltysh
Copy link
Copy Markdown

soltysh commented Dec 14, 2021

This was already fixed in #58.
/close

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 14, 2021

@soltysh: Closed this PR.

Details

In response to this:

This was already fixed in #58.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot closed this Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ensure-yaml-patch failed

4 participants