Skip to content

Updating build-machinery-go to fix the yaml_patch error#1086

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
kwoodson:fix_yaml_patch
Dec 14, 2021
Merged

Updating build-machinery-go to fix the yaml_patch error#1086
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
kwoodson:fix_yaml_patch

Conversation

@kwoodson
Copy link
Copy Markdown

@kwoodson kwoodson commented Dec 14, 2021

I've noticed a few errors locally when attempting to make verify. I'm attempting to update the go.mod to use the latest fix from openshift/build-machinery-go#58

Errors:

Installing yaml-patch into '_output/tools/bin/yaml-patch-v0.0.10'
mkdir -p '_output/tools/bin/'
curl -s -f -L https://github.com/krishicks/yaml-patch/releases/download/v0.0.10/yaml_patch_linux -o '_output/tools/bin/yaml-patch-v0.0.10'
make: *** [ensure-yaml-patch] Error 22
make: *** [Makefile:70: generate-with-container] Error 2

@kwoodson
Copy link
Copy Markdown
Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2021
@openshift-ci openshift-ci Bot requested review from eparis and soltysh December 14, 2021 19:05
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 14, 2021

@kwoodson: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kwoodson kwoodson changed the title Updating build-machiner-go to fix the yaml_patch error Updating build-machinery-go to fix the yaml_patch error Dec 14, 2021
@sttts
Copy link
Copy Markdown
Contributor

sttts commented Dec 14, 2021

/lgtm
/approve

@kwoodson
Copy link
Copy Markdown
Author

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2021
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwoodson, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2021
@openshift-merge-robot openshift-merge-robot merged commit bcf214e into openshift:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants