CORS-2728: Nutanix failure domains support by yanhua121 · Pull Request #1578 · openshift/api

yanhua121 · 2023-09-05T16:06:17Z

https://issues.redhat.com/browse/OCPSTRAT-257

Adding NutanixFailureDomain struct
Adding the optional field FailureDomains to the Infrastructure NutanixPlatformSpec struct
Adding the optional field Nutanix to the ControlPlaneMachineSet FailureDomains struct
Adding the optional field FailureDomainName to the NutanixMachineProviderConfig struct

The proof of concept PRs using the Nutanix failure domains api:
openshift/cluster-control-plane-machine-set-operator#258
openshift/machine-api-provider-nutanix#56

openshift-ci · 2023-09-05T16:06:34Z

Hello @yanhua121! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

yanhua121 · 2023-09-05T20:31:03Z

/assign @JoelSpeed

yanhua121 · 2023-09-06T14:25:44Z

/retest-required

JoelSpeed

Do we have proof of concepts for how this will work with Machines and then ControlPlaneMachineSets? I'm curious as to whether we really need/want to put this failure domain information into the infrastructure object, or just follow the patterns set out by AWS/Azure/GCP for this.

That said, vSphere has embarked on a similar route to this, so perhaps this is a good path forward.

The open questions I have currently are:

How will this work for Machines? How will they be configured and validated
How will this work in a cluster that is upgraded?
How will the CPMS injection the failure domain into the providerSpec/know which machines to update?
Are the failure domains mutable? If so, how can you tell that a machine is correctly installed within a failure domain?

machine/v1/types_controlplanemachineset.go

config/v1/types_infrastructure.go

yanhua121 · 2023-09-12T17:13:46Z

Do we have proof of concepts for how this will work with Machines and then ControlPlaneMachineSets? I'm curious as to whether we really need/want to put this failure domain information into the infrastructure object, or just follow the patterns set out by AWS/Azure/GCP for this.

That said, vSphere has embarked on a similar route to this, so perhaps this is a good path forward.

The open questions I have currently are:

How will this work for Machines? How will they be configured and validated

How will this work in a cluster that is upgraded?

How will the CPMS injection the failure domain into the providerSpec/know which machines to update?

Are the failure domains mutable? If so, how can you tell that a machine is correctly installed within a failure domain?

@JoelSpeed See the feature design doc at https://docs.google.com/document/d/1TA9vCH-3X_GttJ4fHg39sstdhBPCR7S83N1R8rzXFuk/.
We can schedule a meeting to discuss these questions.

JoelSpeed · 2023-09-13T10:58:32Z

@yanhua121 If you have work in progress implementations for the CPMS and Machine related components could you please open the PRs as WIP so that we can review how this code is going to be used in the future

yanhua121 · 2023-09-14T16:39:28Z

@yanhua121 If you have work in progress implementations for the CPMS and Machine related components could you please open the PRs as WIP so that we can review how this code is going to be used in the future

@JoelSpeed Okay. Can you take another look at this PR, I made changes based on your review comments and our discussion.

yanhua121 · 2023-11-06T15:30:49Z

/retest-required

yanhua121 · 2023-11-07T14:55:29Z

/assign @elmiko @rvanderp3

machine/v1/types_nutanixprovider.go

machine/v1/types_controlplanemachineset.go

config/v1/types_infrastructure.go

machine/v1/types_controlplanemachineset.go

machine/v1/types_nutanixprovider.go

config/v1/types_infrastructure.go

JoelSpeed

/lgtm

openshift-ci · 2023-11-20T17:37:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, yanhua121

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2023-11-20T22:17:56Z

@yanhua121: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2023-11-21T06:38:43Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.15.0-202311210610.p0.gb867610.assembly.stream for distgit ose-cluster-config-api.
All builds following this will include this PR.

openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 5, 2023

openshift-ci bot requested review from eparis and mandre September 5, 2023 16:08

yanhua121 force-pushed the ocp-multi-pe branch from cd05cf7 to 7d9a7fb Compare September 5, 2023 19:16

openshift-ci bot assigned JoelSpeed Sep 5, 2023

JoelSpeed reviewed Sep 12, 2023

View reviewed changes

machine/v1/types_controlplanemachineset.go Outdated Show resolved Hide resolved

machine/v1/types_controlplanemachineset.go Outdated Show resolved Hide resolved

config/v1/types_infrastructure.go Outdated Show resolved Hide resolved

config/v1/types_infrastructure.go Show resolved Hide resolved

yanhua121 force-pushed the ocp-multi-pe branch from 7d9a7fb to b9e531c Compare September 12, 2023 16:44

yanhua121 force-pushed the ocp-multi-pe branch from b9e531c to eb37dd4 Compare September 12, 2023 20:15

yanhua121 force-pushed the ocp-multi-pe branch from eb37dd4 to bf3fa11 Compare September 14, 2023 16:29

yanhua121 force-pushed the ocp-multi-pe branch from bf3fa11 to 28f4dcc Compare October 6, 2023 14:58

yanhua121 force-pushed the ocp-multi-pe branch from 28f4dcc to ae2f15c Compare October 23, 2023 22:08

This was referenced Oct 24, 2023

SPLAT-1272: Add support for Nutanix failure domains. openshift/machine-api-provider-nutanix#56

Merged

SPLAT-1272: Add support for Nutanix failure domains openshift/cluster-control-plane-machine-set-operator#258

Merged

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2023

yanhua121 force-pushed the ocp-multi-pe branch from ae2f15c to c0d1f31 Compare October 31, 2023 16:34

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2023

yanhua121 force-pushed the ocp-multi-pe branch 2 times, most recently from bce018a to f63e425 Compare October 31, 2023 17:14

yanhua121 mentioned this pull request Nov 3, 2023

SPLAT-1272: Update for Nutanix failure domains api changes openshift/machine-api-operator#1171

Merged

yanhua121 force-pushed the ocp-multi-pe branch 2 times, most recently from 8387d7d to 7d84778 Compare November 3, 2023 16:48

openshift-ci bot assigned elmiko Nov 7, 2023

openshift-ci bot assigned rvanderp3 Nov 7, 2023

yanhua121 force-pushed the ocp-multi-pe branch from 7d84778 to c3972ac Compare November 15, 2023 19:04

rvanderp3 reviewed Nov 15, 2023

View reviewed changes

machine/v1/types_nutanixprovider.go Outdated Show resolved Hide resolved

rvanderp3 reviewed Nov 15, 2023

View reviewed changes

machine/v1/types_nutanixprovider.go Outdated Show resolved Hide resolved

yanhua121 mentioned this pull request Nov 15, 2023

SPLAT-1272: Update for Nutanix failure domains api changes openshift/cluster-config-operator#378

Merged

rvanderp3 reviewed Nov 15, 2023

View reviewed changes

machine/v1/types_controlplanemachineset.go Show resolved Hide resolved

yanhua121 mentioned this pull request Nov 15, 2023

SPLAT-1272: Support Nutanix Failure Domains openshift/installer#7730

Merged

yanhua121 force-pushed the ocp-multi-pe branch from c3972ac to 333996e Compare November 16, 2023 14:49

JoelSpeed reviewed Nov 16, 2023

View reviewed changes

yanhua121 force-pushed the ocp-multi-pe branch 3 times, most recently from 44627b5 to 8644753 Compare November 17, 2023 18:05

JoelSpeed reviewed Nov 20, 2023

View reviewed changes

config/v1/types_infrastructure.go Show resolved Hide resolved

config/v1/types_infrastructure.go Outdated Show resolved Hide resolved

config/v1/types_infrastructure.go Outdated Show resolved Hide resolved

config/v1/types_infrastructure.go Show resolved Hide resolved

yanhua121 force-pushed the ocp-multi-pe branch from 8644753 to 18bb5b5 Compare November 20, 2023 14:51

Nutanix failure domains support

7f10a1b

yanhua121 force-pushed the ocp-multi-pe branch from 18bb5b5 to 7f10a1b Compare November 20, 2023 16:33

JoelSpeed reviewed Nov 20, 2023

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2023

openshift-merge-bot bot merged commit b867610 into openshift:master Nov 20, 2023

yanhua121 changed the title ~~Nutanix failure domains support~~ CORS-2728: Nutanix failure domains support Dec 11, 2023

Comments

Conversation

yanhua121 commented Sep 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Sep 5, 2023

Uh oh!

yanhua121 commented Sep 5, 2023

Uh oh!

yanhua121 commented Sep 6, 2023

Uh oh!

JoelSpeed left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yanhua121 commented Sep 12, 2023

Uh oh!

JoelSpeed commented Sep 13, 2023

Uh oh!

yanhua121 commented Sep 14, 2023

Uh oh!

yanhua121 commented Nov 6, 2023

Uh oh!

yanhua121 commented Nov 7, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoelSpeed left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Nov 20, 2023

Uh oh!

openshift-ci bot commented Nov 20, 2023

Uh oh!

openshift-bot commented Nov 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

yanhua121 commented Sep 5, 2023 •

edited

Loading