Skip to content

Comments

SPLAT-1272: Add support for Nutanix failure domains.#56

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
nutanix-cloud-native:nutanix-failuredomains
Nov 21, 2023
Merged

SPLAT-1272: Add support for Nutanix failure domains.#56
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
nutanix-cloud-native:nutanix-failuredomains

Conversation

@yanhua121
Copy link
Contributor

@yanhua121 yanhua121 commented Oct 24, 2023 •
edited
Loading

Add support for Nutanix failure domains.

Depends on the below PRs:
openshift/api#1578
openshift/machine-api-operator#1171

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@yanhua121 yanhua121 force-pushed the nutanix-failuredomains branch from 6c9d554 to a9f72c3 Compare October 31, 2023 18:39
@yanhua121 yanhua121 mentioned this pull request Nov 3, 2023
Merged
@yanhua121 yanhua121 changed the title WIP: test Nutanix failure domains Add support for Nutanix failure domains. Nov 3, 2023
@yanhua121 yanhua121 marked this pull request as ready for review November 3, 2023 14:41
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2023
@openshift-ci openshift-ci bot requested review from JoelSpeed and racheljpg November 3, 2023 14:46
@yanhua121 yanhua121 force-pushed the nutanix-failuredomains branch 2 times, most recently from 7be93d2 to 33e3fe6 Compare November 6, 2023 18:21
@yanhua121
Copy link
Contributor Author

yanhua121 commented Nov 7, 2023

/assign @elmiko

@yanhua121 yanhua121 mentioned this pull request Nov 7, 2023
Merged
elmiko
elmiko reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me, i just have a suggestion/question about a couple error log messages.

@yanhua121 yanhua121 force-pushed the nutanix-failuredomains branch from 33e3fe6 to b013537 Compare November 8, 2023 00:31
elmiko
elmiko reviewed Nov 8, 2023
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @yanhua121

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2023
@elmiko
Copy link
Contributor

elmiko commented Nov 8, 2023

as discussed with @yanhua121 in slack, this requires openshift/api#1578 and openshift/machine-api-operator#1171

feel free to remove hold when ready
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2023
@yanhua121 yanhua121 force-pushed the nutanix-failuredomains branch from b013537 to 7c3e6f1 Compare November 15, 2023 19:48
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2023
@yanhua121 yanhua121 force-pushed the nutanix-failuredomains branch 2 times, most recently from 260badc to 56047cf Compare November 17, 2023 21:48
@yanhua121
Copy link
Contributor Author

yanhua121 commented Nov 18, 2023

/test e2e-nutanix-operator

JoelSpeed
JoelSpeed reviewed Nov 20, 2023
View reviewed changes
@yanhua121 yanhua121 force-pushed the nutanix-failuredomains branch 2 times, most recently from 3f0ee75 to 32adae8 Compare November 21, 2023 03:26
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Nov 21, 2023

/label acknowledge-critical-fixes-only

This PR only affects the nutanix platform and the CI for nutanix is green. Nutanix is also not a release blocking platform so this won't affect payload acceptance

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 21, 2023
@yanhua121
Copy link
Contributor Author

yanhua121 commented Nov 21, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2023
@yanhua121 yanhua121 changed the title Add support for Nutanix failure domains. SPLAT-1272: Add support for Nutanix failure domains. Nov 21, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 21, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2023 •
edited by openshift-ci bot
Loading

@yanhua121: This pull request references SPLAT-1272 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Add support for Nutanix failure domains.

Depends on the below PRs:
openshift/api#1578
openshift/machine-api-operator#1171

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yanhua121 yanhua121 force-pushed the nutanix-failuredomains branch from 32adae8 to c77bec9 Compare November 21, 2023 19:11
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2023

@yanhua121: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elmiko
Copy link
Contributor

elmiko commented Nov 21, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit eb4a44a into openshift:main Nov 21, 2023
@openshift-bot
Copy link

openshift-bot commented Nov 22, 2023

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-nutanix-machine-controllers-container-v4.15.0-202311220209.p0.geb4a44a.assembly.stream for distgit ose-nutanix-machine-controllers.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@racheljpg racheljpg Awaiting requested review from racheljpg

+1 more reviewer

@elmiko elmiko elmiko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@elmiko elmiko

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yanhua121 @elmiko @JoelSpeed @openshift-ci-robot @openshift-bot