Skip to content

Comments

SPLAT-1272: Update for Nutanix failure domains api changes#378

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
yanhua121:nutanix-failuredomains
Nov 21, 2023
Merged

SPLAT-1272: Update for Nutanix failure domains api changes#378
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
yanhua121:nutanix-failuredomains

Conversation

@yanhua121
Copy link
Contributor

Update for Nutanix failure domains api changes.

Depends on openshift/api#1578

@openshift-ci openshift-ci bot requested review from deads2k and tkashem November 15, 2023 19:28
@yanhua121 yanhua121 force-pushed the nutanix-failuredomains branch 2 times, most recently from 02647cf to a7530b8 Compare November 20, 2023 23:34
@yanhua121 yanhua121 force-pushed the nutanix-failuredomains branch from a7530b8 to ee4c2c6 Compare November 21, 2023 15:21
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, yanhua121

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2023

@yanhua121: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yanhua121
Copy link
Contributor Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 21, 2023
@yanhua121 yanhua121 changed the title Update for Nutanix failure domains api changes SPLAT-1272: Update for Nutanix failure domains api changes Nov 21, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 21, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2023

@yanhua121: This pull request references SPLAT-1272 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Update for Nutanix failure domains api changes.

Depends on openshift/api#1578

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 5e1b86f into openshift:master Nov 21, 2023
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-operator-container-v4.15.0-202311220209.p0.g5e1b86f.assembly.stream for distgit ose-cluster-config-operator.
All builds following this will include this PR.

kyrtapz pushed a commit to kyrtapz/cluster-config-operator that referenced this pull request Nov 22, 2023
SPLAT-1272: Update for Nutanix failure domains api changes
Signed-off-by: Patryk Diak <pdiak@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants