Skip to content

Comments

SPLAT-1272: Update for Nutanix failure domains api changes#1171

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
nutanix-cloud-native:nutanix-failuredomain
Nov 21, 2023
Merged

SPLAT-1272: Update for Nutanix failure domains api changes#1171
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
nutanix-cloud-native:nutanix-failuredomain

Conversation

@yanhua121
Copy link
Contributor

@yanhua121 yanhua121 commented Oct 24, 2023 •
edited
Loading

Update for Nutanix failure domains api changes.
Depends on the api PR: openshift/api#1578

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@yanhua121 yanhua121 mentioned this pull request Oct 25, 2023
Merged
@yanhua121 yanhua121 force-pushed the nutanix-failuredomain branch from 5441e1e to c9d3792 Compare October 31, 2023 18:18
@yanhua121 yanhua121 changed the title WIP: vendor bump to test Nutanix failure domains Update for Nutanix failure domains api changes Nov 3, 2023
@yanhua121 yanhua121 marked this pull request as ready for review November 3, 2023 14:38
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2023
@yanhua121 yanhua121 mentioned this pull request Nov 3, 2023
Merged
@openshift-ci openshift-ci bot requested review from JoelSpeed and elmiko November 3, 2023 14:44
@yanhua121
Copy link
Contributor Author

yanhua121 commented Nov 7, 2023

/retest-required

@yanhua121 yanhua121 force-pushed the nutanix-failuredomain branch from c9d3792 to 424ce7b Compare November 7, 2023 14:38
@yanhua121 yanhua121 force-pushed the nutanix-failuredomain branch from 424ce7b to 2d13a71 Compare November 15, 2023 19:37
elmiko
elmiko reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just need to fix the replace statements when the others merge.

@yanhua121 yanhua121 marked this pull request as draft November 17, 2023 18:37
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2023
@yanhua121 yanhua121 force-pushed the nutanix-failuredomain branch from 2d13a71 to 5a95b2b Compare November 18, 2023 02:41
@yanhua121 yanhua121 marked this pull request as ready for review November 18, 2023 02:44
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2023
@yanhua121
Copy link
Contributor Author

yanhua121 commented Nov 18, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2023
@openshift-ci openshift-ci bot requested a review from elmiko November 18, 2023 02:45
@yanhua121 yanhua121 force-pushed the nutanix-failuredomain branch from 5a95b2b to df9d27d Compare November 20, 2023 23:44
@yanhua121
Copy link
Contributor Author

yanhua121 commented Nov 21, 2023

/retest

@yanhua121
Copy link
Contributor Author

yanhua121 commented Nov 21, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2023
@yanhua121 yanhua121 force-pushed the nutanix-failuredomain branch from df9d27d to 88c9b14 Compare November 21, 2023 15:28
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Nov 21, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2023
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Nov 21, 2023

/label acknowledge-critical-fixes-only

This should be a benign change, no concern about breaking things here if the CI is stable

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Nov 21, 2023
@yanhua121 yanhua121 changed the title Update for Nutanix failure domains api changes SPLAT-1272: Update for Nutanix failure domains api changes Nov 21, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 21, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 21, 2023 •
edited by openshift-ci bot
Loading

@yanhua121: This pull request references SPLAT-1272 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Update for Nutanix failure domains api changes.
Depends on the api PR: openshift/api#1578

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit ada49bd into openshift:master Nov 21, 2023
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 22, 2023

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-api-operator-container-v4.15.0-202311220209.p0.gada49bd.assembly.stream for distgit ose-machine-api-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@elmiko elmiko Awaiting requested review from elmiko

Assignees

@JoelSpeed JoelSpeed

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yanhua121 @JoelSpeed @openshift-ci-robot @openshift-bot @elmiko