SPLAT-1272: Add support for Nutanix failure domains by yanhua121 · Pull Request #258 · openshift/cluster-control-plane-machine-set-operator

yanhua121 · 2023-10-25T13:55:20Z

Add support for Nutanix failure domains.

The associated PRs:
openshift/api#1578: extends API for Nutanix FailureDomains
openshift/client-go#259: update with the Nutanix FailureDomains APIs
openshift/machine-api-operator#1171: update with the Nutanix FailureDomains APIs
openshift/machine-api-provider-nutanix#56: Add support Nutanix failure domains
openshift/cluster-api-actuator-pkg#304: create fixtures for Nutanix failure domains support

openshift-ci · 2023-10-25T13:56:55Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

yanhua121 · 2023-11-07T14:55:54Z

/assign @JoelSpeed @elmiko @rvanderp3

rvanderp3 · 2023-11-15T18:59:58Z

Hi @yanhua121 , the linter issue needs to be resolved and could you break the revendoring in to its own commit?

pkg/util/nutanix.go

pkg/controllers/controlplanemachinesetgenerator/nutanix.go

elmiko

i think this generally makes sense to me, but i have a couple questions.

also, will probably need @JoelSpeed to give a review as well.

go.mod

pkg/util/nutanix.go

JoelSpeed

/hold

There's a significant number of comments here that I'd like to see resolved

go.mod

pkg/controllers/controlplanemachinesetgenerator/controller_test.go

pkg/controllers/controlplanemachinesetgenerator/nutanix.go

pkg/util/nutanix.go

openshift-ci-robot · 2023-11-23T08:26:49Z

@yanhua121: This pull request references SPLAT-1272 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Add support for Nutanix failure domains.

The associated PRs:
openshift/api#1578: extends API for Nutanix FailureDomains
openshift/client-go#259: update with the Nutanix FailureDomains APIs
openshift/machine-api-operator#1171: update with the Nutanix FailureDomains APIs
openshift/machine-api-provider-nutanix#56: Add support Nutanix failure domains
openshift/cluster-api-actuator-pkg#304: create fixtures for Nutanix failure domains support

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yanhua121 · 2023-11-28T02:34:11Z

/retest-required

elmiko

this lgtm, we need to update the go.mod after the other pr merges but i'm ok with what is here.

i'd like @JoelSpeed to take another look tomorrow

yanhua121 · 2023-11-30T02:50:38Z

/retest-required

JoelSpeed

LGTM, just need to fix the replace in the go.mod and then we are good to go

yanhua121 · 2023-11-30T14:28:33Z

/unhold

JoelSpeed · 2023-11-30T18:19:01Z

/lgtm
/approve

openshift-ci · 2023-11-30T18:27:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2023-11-30T19:11:45Z

/retest-required

Remaining retests: 0 against base HEAD 800e341 and 2 for PR HEAD 7e71c46 in total

openshift-ci · 2023-11-30T21:23:38Z

@yanhua121: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-nutanix-ovn	`7e71c46`	link	false	`/test e2e-nutanix-ovn`
ci/prow/e2e-vsphere-ovn-etcd-scaling	`7e71c46`	link	false	`/test e2e-vsphere-ovn-etcd-scaling`
ci/prow/e2e-vsphere-multi-zone-operator	`7e71c46`	link	false	`/test e2e-vsphere-multi-zone-operator`
ci/prow/e2e-vsphere-operator	`7e71c46`	link	false	`/test e2e-vsphere-operator`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2023-12-01T02:59:33Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-control-plane-machine-set-operator-container-v4.15.0-202312010209.p0.g2de2930.assembly.stream for distgit ose-cluster-control-plane-machine-set-operator.
All builds following this will include this PR.

damdo · 2023-12-04T16:33:14Z

@yanhua121 now that this one merged, we will need a doc update for CPMS Nutanix similar to this one we are doing for VSphere.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2023

openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 25, 2023

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2023

yanhua121 force-pushed the nutanix-failuredomains branch 2 times, most recently from 6c2785d to 9920824 Compare October 30, 2023 22:02

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2023

openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 30, 2023

yanhua121 force-pushed the nutanix-failuredomains branch from 9920824 to 3704bbe Compare November 2, 2023 17:31

openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 2, 2023

yanhua121 force-pushed the nutanix-failuredomains branch from 3704bbe to cb2c85a Compare November 3, 2023 14:21

yanhua121 changed the title ~~WIP: adding support for Nutanix failure domains~~ Add support for Nutanix failure domains Nov 3, 2023

yanhua121 marked this pull request as ready for review November 3, 2023 14:26

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2023

openshift-ci bot requested review from damdo and nrb November 3, 2023 14:28

yanhua121 force-pushed the nutanix-failuredomains branch 2 times, most recently from 12c0943 to bad9d82 Compare November 7, 2023 05:44

openshift-ci bot assigned elmiko, JoelSpeed and rvanderp3 Nov 7, 2023

yanhua121 mentioned this pull request Nov 7, 2023

CORS-2728: Nutanix failure domains support openshift/api#1578

Merged

rvanderp3 reviewed Nov 15, 2023

View reviewed changes

pkg/util/nutanix.go Outdated Show resolved Hide resolved

rvanderp3 reviewed Nov 15, 2023

View reviewed changes

pkg/controllers/controlplanemachinesetgenerator/nutanix.go Outdated Show resolved Hide resolved

rvanderp3 reviewed Nov 15, 2023

View reviewed changes

pkg/controllers/controlplanemachinesetgenerator/nutanix.go Outdated Show resolved Hide resolved

yanhua121 force-pushed the nutanix-failuredomains branch from bad9d82 to c173478 Compare November 15, 2023 21:03

elmiko reviewed Nov 21, 2023

View reviewed changes

go.mod Outdated Show resolved Hide resolved

pkg/util/nutanix.go Outdated Show resolved Hide resolved

pkg/util/nutanix.go Outdated Show resolved Hide resolved

JoelSpeed reviewed Nov 22, 2023

View reviewed changes

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2023

yanhua121 force-pushed the nutanix-failuredomains branch from 5a21c59 to 873b8b7 Compare November 23, 2023 08:25

yanhua121 force-pushed the nutanix-failuredomains branch from 873b8b7 to b4dd62f Compare November 27, 2023 18:12

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 27, 2023

yanhua121 force-pushed the nutanix-failuredomains branch from b4dd62f to 75d34e9 Compare November 28, 2023 00:04

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2023

yanhua121 force-pushed the nutanix-failuredomains branch 3 times, most recently from f3ae7cb to 29be7fa Compare November 29, 2023 22:18

elmiko reviewed Nov 29, 2023

View reviewed changes

JoelSpeed reviewed Nov 30, 2023

View reviewed changes

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2023

Adding support for Nutanix failure domains

7e71c46

yanhua121 force-pushed the nutanix-failuredomains branch from 29be7fa to 7e71c46 Compare November 30, 2023 14:37

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2023

openshift-merge-bot bot merged commit 2de2930 into openshift:main Nov 30, 2023

damdo mentioned this pull request Jan 8, 2025

NO-JIRA: Update support matrix #339

Merged

Comments

Conversation

yanhua121 commented Oct 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Oct 25, 2023

Uh oh!

yanhua121 commented Nov 7, 2023

Uh oh!

rvanderp3 commented Nov 15, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elmiko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoelSpeed left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 23, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yanhua121 commented Nov 28, 2023

Uh oh!

elmiko left a comment

Choose a reason for hiding this comment

Uh oh!

yanhua121 commented Nov 30, 2023

Uh oh!

JoelSpeed left a comment

Choose a reason for hiding this comment

Uh oh!

yanhua121 commented Nov 30, 2023

Uh oh!

JoelSpeed commented Nov 30, 2023

Uh oh!

openshift-ci bot commented Nov 30, 2023

Uh oh!

openshift-ci-robot commented Nov 30, 2023

Uh oh!

openshift-ci bot commented Nov 30, 2023

Uh oh!

openshift-bot commented Dec 1, 2023

Uh oh!

damdo commented Dec 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

yanhua121 commented Oct 25, 2023 •

edited

Loading

openshift-ci-robot commented Nov 23, 2023 •

edited by openshift-ci bot

Loading