SPLAT-1272: Support Nutanix Failure Domains by yanhua121 · Pull Request #7730 · openshift/installer

yanhua121 · 2023-11-15T19:59:08Z

Nutanix Failure Domains support

Depends on openshift/api#1578

rvanderp3 · 2023-11-15T20:05:11Z

/hold

openshift/api#1578 must merge and this must be revendored

pkg/asset/machines/nutanix/machinesets.go

pkg/types/nutanix/helpers.go

jcpowermac · 2023-11-15T20:56:22Z

I don't see any changes the platform spec validation

https://github.com/openshift/installer/blob/master/pkg/types/nutanix/validation/platform.go

yanhua121 · 2023-11-16T05:27:46Z

I don't see any changes the platform spec validation
https://github.com/openshift/installer/blob/master/pkg/types/nutanix/validation/platform.go

@jcpowermac Added some validation for the failure domains configuration in this file.

yanhua121 · 2023-11-16T14:41:41Z

/retest-required

jcpowermac · 2023-11-16T20:58:12Z

@yanhua121 you might want to start taking a look at golint since we are waiting on the api changes. There is a few items in there to fix.

pkg/types/nutanix/platform.go

pkg/types/nutanix/validation/platform.go

openshift-ci-robot · 2023-11-21T18:41:05Z

@yanhua121: This pull request references SPLAT-1272 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Nutanix Failure Domains support

Depends on openshift/api#1578

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yanhua121 · 2023-11-22T16:24:26Z

@jcpowermac The api dependency versioning is updated, and all your review comments are addressed. The go-lint test also passed. Could you take another look, thanks.

yanhua121 · 2023-11-22T19:53:34Z

/retest-required

jcpowermac · 2023-11-22T21:21:41Z

/hold cancel

jcpowermac · 2023-11-22T21:21:57Z

/test e2e-nutanix-ovn

jcpowermac · 2023-11-22T21:23:56Z

/assign @jhixson74

jcpowermac · 2023-11-22T21:25:46Z

/lgtm

r4f4 · 2023-11-27T15:27:19Z

Please separate vendor changes into their own commit.

yanhua121 · 2023-11-27T16:42:29Z

Please separate vendor changes into their own commit.

@r4f4 Should the go.mod and go.sum changes be included in the vendor commit?

r4f4 · 2023-11-27T17:07:54Z

Please separate vendor changes into their own commit.

@r4f4 Should the go.mod and go.sum changes be included in the vendor commit?

There is no clear consensus on that. I know that @patrickdillon prefers separate commits (go.{mod,sum} in one commit and vendor/ in another).

yanhua121 · 2023-11-27T19:11:30Z

@r4f4 All your comments are addressed. Could you take another look?

jcpowermac · 2023-11-27T19:13:02Z

/lgtm

rvanderp3 · 2023-11-27T19:24:01Z

/assign @patrickdillon

pkg/asset/machines/nutanix/machines.go

pkg/asset/manifests/nutanix/infrastructure.go

…port

patrickdillon · 2023-11-27T20:42:39Z

There is no clear consensus on that. I know that @patrickdillon prefers separate commits (go.{mod,sum} in one commit and vendor/ in another).

Either way is fine. After learning about separating go.mod & go.sum into separate commits from the installer docs I have found it beneficial in my own workflow.

r4f4

/lgtm

yanhua121 · 2023-11-27T21:18:54Z

/retest-required

jcpowermac · 2023-11-27T22:55:32Z

/retest-required

patrickdillon · 2023-11-27T23:03:22Z

/approve

openshift-ci · 2023-11-27T23:06:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

yanhua121 · 2023-11-28T04:30:11Z

/retest-required

openshift-ci · 2023-11-28T11:59:05Z

@yanhua121: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-shared-vpc-localzones	e72a6b5da5ab579014fbf9bcdc60e6c582c8e982	link	false	`/test e2e-aws-ovn-shared-vpc-localzones`
ci/prow/e2e-azurestack	e72a6b5da5ab579014fbf9bcdc60e6c582c8e982	link	false	`/test e2e-azurestack`
ci/prow/e2e-aws-ovn-fips	e72a6b5da5ab579014fbf9bcdc60e6c582c8e982	link	false	`/test e2e-aws-ovn-fips`
ci/prow/e2e-openstack-sdn-parallel	e72a6b5da5ab579014fbf9bcdc60e6c582c8e982	link	false	`/test e2e-openstack-sdn-parallel`
ci/prow/e2e-azure-ovn-shared-vpc	e72a6b5da5ab579014fbf9bcdc60e6c582c8e982	link	false	`/test e2e-azure-ovn-shared-vpc`
ci/prow/e2e-gcp-ovn-xpn	e72a6b5da5ab579014fbf9bcdc60e6c582c8e982	link	false	`/test e2e-gcp-ovn-xpn`
ci/prow/e2e-aws-ovn-single-node	e72a6b5da5ab579014fbf9bcdc60e6c582c8e982	link	false	`/test e2e-aws-ovn-single-node`
ci/prow/openstack-manifests	e72a6b5da5ab579014fbf9bcdc60e6c582c8e982	link	true	`/test openstack-manifests`
ci/prow/e2e-gcp-secureboot	e72a6b5da5ab579014fbf9bcdc60e6c582c8e982	link	false	`/test e2e-gcp-secureboot`
ci/prow/e2e-openstack-proxy	e72a6b5da5ab579014fbf9bcdc60e6c582c8e982	link	false	`/test e2e-openstack-proxy`
ci/prow/e2e-openstack-ovn	e72a6b5da5ab579014fbf9bcdc60e6c582c8e982	link	true	`/test e2e-openstack-ovn`
ci/prow/e2e-gcp-ovn-shared-vpc	e72a6b5da5ab579014fbf9bcdc60e6c582c8e982	link	false	`/test e2e-gcp-ovn-shared-vpc`
ci/prow/e2e-aws-custom-security-groups	e72a6b5da5ab579014fbf9bcdc60e6c582c8e982	link	false	`/test e2e-aws-custom-security-groups`
ci/prow/e2e-aws-ovn-localzones	e72a6b5da5ab579014fbf9bcdc60e6c582c8e982	link	false	`/test e2e-aws-ovn-localzones`
ci/prow/e2e-aws-ovn-imdsv2	e72a6b5da5ab579014fbf9bcdc60e6c582c8e982	link	false	`/test e2e-aws-ovn-imdsv2`
ci/prow/e2e-aws-ovn-shared-vpc	e72a6b5da5ab579014fbf9bcdc60e6c582c8e982	link	false	`/test e2e-aws-ovn-shared-vpc`
ci/prow/okd-e2e-aws-ovn-upgrade	`5f01650`	link	false	`/test okd-e2e-aws-ovn-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2023-11-28T18:51:49Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.15.0-202311281631.p0.g8032847.assembly.stream for distgit ose-installer-altinfra.
All builds following this will include this PR.

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2023

openshift-ci bot requested review from andfasano and jhixson74 November 15, 2023 20:31

jcpowermac reviewed Nov 15, 2023

View reviewed changes

pkg/asset/machines/nutanix/machinesets.go Outdated Show resolved Hide resolved

jcpowermac reviewed Nov 15, 2023

View reviewed changes

pkg/asset/machines/nutanix/machinesets.go Outdated Show resolved Hide resolved

jcpowermac reviewed Nov 15, 2023

View reviewed changes

pkg/types/nutanix/helpers.go Outdated Show resolved Hide resolved

yanhua121 force-pushed the nutanix-failuredomains branch 2 times, most recently from 0c51b58 to 06963b0 Compare November 16, 2023 05:25

yanhua121 force-pushed the nutanix-failuredomains branch from 06963b0 to 570f643 Compare November 18, 2023 02:49

jcpowermac reviewed Nov 20, 2023

View reviewed changes

pkg/types/nutanix/platform.go Outdated Show resolved Hide resolved

jcpowermac reviewed Nov 20, 2023

View reviewed changes

pkg/types/nutanix/validation/platform.go Outdated Show resolved Hide resolved

yanhua121 changed the title ~~Support Nutanix Failure Domains~~ SPLAT-1272: Support Nutanix Failure Domains Nov 21, 2023

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 21, 2023

yanhua121 force-pushed the nutanix-failuredomains branch from 570f643 to f4b3f5c Compare November 22, 2023 05:25

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2023

yanhua121 force-pushed the nutanix-failuredomains branch from f4b3f5c to e72a6b5 Compare November 22, 2023 14:49

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2023

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023

yanhua121 force-pushed the nutanix-failuredomains branch from bee9978 to f2e410a Compare November 27, 2023 16:31

yanhua121 force-pushed the nutanix-failuredomains branch from f2e410a to 2dd6d78 Compare November 27, 2023 16:47

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023

r4f4 reviewed Nov 27, 2023

View reviewed changes

pkg/asset/machines/nutanix/machines.go Outdated Show resolved Hide resolved

pkg/asset/manifests/nutanix/infrastructure.go Outdated Show resolved Hide resolved

pkg/asset/manifests/nutanix/infrastructure.go Outdated Show resolved Hide resolved

yanhua121 added 2 commits November 27, 2023 15:00

SPLAT-1272: Vendor dependency changes for Nutanix Failure Domains sup…

2bc5efb

…port

SPLAT-1272: Support Nutanix Failure Domains

5f01650

openshift-ci bot assigned patrickdillon Nov 27, 2023

yanhua121 force-pushed the nutanix-failuredomains branch from 2dd6d78 to 5f01650 Compare November 27, 2023 20:26

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023

r4f4 reviewed Nov 27, 2023

View reviewed changes

openshift-ci bot assigned r4f4 Nov 27, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2023

openshift-merge-bot bot merged commit 8032847 into openshift:master Nov 28, 2023

yanhua121 mentioned this pull request Dec 6, 2023

SPLAT-1272: Modify the terraform variables to support Nutanix Failure Domains #7806

Merged

Comments

Conversation

yanhua121 commented Nov 15, 2023

Uh oh!

rvanderp3 commented Nov 15, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jcpowermac commented Nov 15, 2023

Uh oh!

yanhua121 commented Nov 16, 2023

Uh oh!

yanhua121 commented Nov 16, 2023

Uh oh!

jcpowermac commented Nov 16, 2023

Uh oh!

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 21, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yanhua121 commented Nov 22, 2023

Uh oh!

yanhua121 commented Nov 22, 2023

Uh oh!

jcpowermac commented Nov 22, 2023

Uh oh!

jcpowermac commented Nov 22, 2023

Uh oh!

jcpowermac commented Nov 22, 2023

Uh oh!

jcpowermac commented Nov 22, 2023

Uh oh!

r4f4 commented Nov 27, 2023

Uh oh!

yanhua121 commented Nov 27, 2023

Uh oh!

r4f4 commented Nov 27, 2023

Uh oh!

yanhua121 commented Nov 27, 2023

Uh oh!

jcpowermac commented Nov 27, 2023

Uh oh!

rvanderp3 commented Nov 27, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

patrickdillon commented Nov 27, 2023

Uh oh!

r4f4 left a comment

Choose a reason for hiding this comment

Uh oh!

yanhua121 commented Nov 27, 2023

Uh oh!

jcpowermac commented Nov 27, 2023

Uh oh!

patrickdillon commented Nov 27, 2023

Uh oh!

openshift-ci bot commented Nov 27, 2023

Uh oh!

yanhua121 commented Nov 28, 2023

Uh oh!

openshift-ci bot commented Nov 28, 2023

Uh oh!

openshift-bot commented Nov 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

openshift-ci-robot commented Nov 21, 2023 •

edited by openshift-ci bot

Loading