Skip to content

OCPBUGS-13914: allow removal of vsphereStorageDriver field in 4.14#378

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
dobsonj:OCPBUGS-13914
Jun 15, 2023
Merged

OCPBUGS-13914: allow removal of vsphereStorageDriver field in 4.14#378
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
dobsonj:OCPBUGS-13914

Conversation

@dobsonj
Copy link
Member

@dobsonj dobsonj commented May 31, 2023 •
edited
Loading

https://issues.redhat.com/browse/OCPBUGS-13914

This bumps openshift/api to get openshift/api@6a9f31b and openshift/api@2346bf9 to get the CRD changes with the updated validation rules and the new secrets store provider in ClusterCSIDriver.

cc @openshift/storage

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 31, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 31, 2023

@dobsonj: This pull request references Jira Issue OCPBUGS-13914, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ropatil010

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-13914

This bumps openshift/api to openshift/api@2346bf9 to get the CRD changes with the updated validation rules.

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from gnufied, ropatil010 and tsmetana May 31, 2023 16:42
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2023
@dobsonj
Copy link
Member Author

dobsonj commented May 31, 2023

/hold
I'll rebase this after #376 merges, since that fixes the featuregate API changes.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2023
@dobsonj
Copy link
Member Author

dobsonj commented May 31, 2023

I also may want to wait to bump api after openshift/api#1456 merges to get the new provider name into the ClusterCSIDriver at the same time.

@dobsonj
Copy link
Member Author

dobsonj commented Jun 13, 2023

Latest push rebases on top of #376 and bumps API to openshift/api@6a9f31b
/hold for #376 to merge first

@dobsonj
Copy link
Member Author

dobsonj commented Jun 14, 2023 •
edited
Loading

The PR that this depended on merged, and the latest push rebases on that
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 14, 2023

@dobsonj: This pull request references Jira Issue OCPBUGS-13914, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ropatil010

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-13914

This bumps openshift/api to get openshift/api@6a9f31b and openshift/api@2346bf9 to get the CRD changes with the updated validation rules and the new secrets store provider in ClusterCSIDriver.

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bertinatto
bertinatto reviewed Jun 14, 2023
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 14, 2023

/retest-required

Remaining retests: 0 against base HEAD a224805 and 2 for PR HEAD a1eaa51 in total

@dobsonj
Copy link
Member Author

dobsonj commented Jun 14, 2023

/retest-required

@jsafrane
Copy link
Contributor

jsafrane commented Jun 15, 2023 •
edited
Loading

util.go:457: Container socks5-proxy in pod openshift-apiserver-55ff44699d-dg5m9 has a restartCount > 0 (2)

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2023

@dobsonj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ovn-vsphere a1eaa51 link false /test e2e-ovn-vsphere
ci/prow/e2e-azure-file-csi a1eaa51 link false /test e2e-azure-file-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit cf2524d into openshift:master Jun 15, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 15, 2023

@dobsonj: Jira Issue OCPBUGS-13914: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13914 has been moved to the MODIFIED state.

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-13914

This bumps openshift/api to get openshift/api@6a9f31b and openshift/api@2346bf9 to get the CRD changes with the updated validation rules and the new secrets store provider in ClusterCSIDriver.

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ropatil010 ropatil010 Awaiting requested review from ropatil010

@gnufied gnufied Awaiting requested review from gnufied

@tsmetana tsmetana Awaiting requested review from tsmetana

1 more reviewer

@bertinatto bertinatto bertinatto left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@bertinatto bertinatto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dobsonj @openshift-ci-robot @jsafrane @bertinatto @openshift-merge-robot

Comments