add ability to detect vsphere csi migration#1490
add ability to detect vsphere csi migration#1490elmiko wants to merge 1 commit intoopenshift:masterfrom
Conversation
Due to changes in upstream kubernetes, the vSphere in-tree cloud provider will need to be used in situations where the in-tree storage is still in use. Because OpenShift 4.13 is enabling CSI migration by default for vSphere, there will need to be a regression method for the CCM as well. This change transforms the IsCloudProviderExternal function to detect this condition. references: https://groups.google.com/g/kubernetes-sig-storage/c/wvJpNDBS9vU kubernetes/kubernetes#116342 https://issues.redhat.com/browse/STOR-1265
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
this will require openshift/api#1423 before it can work |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| return false, err | ||
| } | ||
|
|
||
| return !disabledFeatureGates.Has(configv1.InTreeVSphereVolumes) && enabledFeatureGates.Has(configv1.InTreeVSphereVolumes), nil |
There was a problem hiding this comment.
InTreeVSphereVolumes is the FeatureSet that disables the CSIMigrationvSphere FeatureGate here, so this line should check for CSIMigrationvSphere instead.
There was a problem hiding this comment.
so, just to be clear here, the CSIMigrationvSphere needs to be in the disabled list?
|
it seems like we will go another direction that is more specific in the mco. i am closing this. |
2 participants
Due to changes in upstream kubernetes, the vSphere in-tree cloud provider will need to be used in situations where the in-tree storage is still in use. Because OpenShift 4.13 is enabling CSI migration by default for vSphere, there will need to be a regression method for the CCM as well. This change transforms the IsCloudProviderExternal function to detect this condition.
references:
https://groups.google.com/g/kubernetes-sig-storage/c/wvJpNDBS9vU
kubernetes/kubernetes#116342
https://issues.redhat.com/browse/STOR-1265