MGMT-20897: Add new Openshift AI - no GPU validation

[ammont82]

Related with https://issues.redhat.com/browse/MGMT-20897

Add a cluster validation for openshift-ai.

If the cluster has no GPU, a warning in the front should be displayed.
This validation appears in "Host Discovery" step.

Summary by CodeRabbit

• New Features

  • Added support for GPU requirements validation in the cluster wizard.

• Improvements

  • Introduced arbiter node requirements to cluster host requirements details.

• Other Changes

  • Removed an outdated feature support level related to skipping MCO reboot.

[openshift-ci-robot]

@ammont82: This pull request references MGMT-20897 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Related with https://issues.redhat.com/browse/MGMT-20897

Add a cluster validation for openshift-ai.

If the cluster has no GPU, a warning in the front should be displayed.
This validation appears in "Host Discovery" step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

A new validation ID related to OpenShift AI GPU requirements was added to both the type definitions and the wizard transition logic. Additionally, a feature support level value was removed, and an optional arbiter node requirements property was introduced in the type definitions.

Changes

File(s)	Change Summary
libs/types/assisted-installer-service.d.ts	Added new validation ID to ClusterValidationId, removed 'SKIP_MCO_REBOOT' from FeatureSupportLevelId, and added optional arbiter property to VersionedHostRequirements.
libs/ui-lib/lib/ocm/components/clusterWizard/wizardTransition.ts	Added 'openshift-ai-gpu-requirements-satisfied' to the soft validation IDs array.

Estimated code review effort

1 (<30 minutes)

Suggested labels

lgtm, size/XS

Suggested reviewers

• ammont82
• celdrake

Poem

A bunny with specs on its nose,
Hopped through the code as it grows.
With GPU checks now in place,
And arbiter nodes in the race,
It nibbled the docs,
And left happy pawprints in code blocks! 🐇

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

libs/types/assisted-installer-service.d.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "@openshift-assisted/eslint-config" to extend from. Please check that the name of the config is correct.

The config "@openshift-assisted/eslint-config" was referenced from the config file in "/libs/types/.eslintrc.cjs".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

libs/ui-lib/lib/ocm/components/clusterWizard/wizardTransition.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "@openshift-assisted/eslint-config" to extend from. Please check that the name of the config is correct.

The config "@openshift-assisted/eslint-config" was referenced from the config file in "/libs/ui-lib/.eslintrc.cjs".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6879f03 and 1abb37f.

📒 Files selected for processing (2)

• libs/types/assisted-installer-service.d.ts (2 hunks)
• libs/ui-lib/lib/ocm/components/clusterWizard/wizardTransition.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: tests
• GitHub Check: circular-deps
• GitHub Check: format
• GitHub Check: lint
• GitHub Check: translation-files
• GitHub Check: unit-tests

🔇 Additional comments (3)

libs/types/assisted-installer-service.d.ts (2)

676-676: LGTM! Well-structured validation ID addition.

The new 'openshift-ai-gpu-requirements-satisfied' validation ID follows the established naming convention and is appropriately placed after the general OpenShift AI validation. This aligns perfectly with the PR objective of adding GPU validation for OpenShift AI workloads.

---

931-934: LGTM! Consistent interface extension for arbiter nodes.

The addition of the optional arbiter property follows the same pattern as the existing master and worker properties, providing consistent support for arbiter node requirements in OpenShift cluster configurations.

libs/ui-lib/lib/ocm/components/clusterWizard/wizardTransition.ts (1)

194-199: LGTM! Proper integration of GPU validation into wizard flow.

The addition of 'openshift-ai-gpu-requirements-satisfied' to the softValidationIds array is correctly placed in the hostDiscoveryStepValidationsMap. This ensures the GPU validation:

1. Runs during the host discovery step as intended
2. Shows as a warning rather than blocking installation (appropriate for GPU availability)
3. Aligns with the PR objective of informing users about GPU absence during cluster setup

The placement among other soft validations (disk and agent compatibility) is logical and consistent.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ammont82]

/cherry-pick releases/v2.43

[openshift-cherrypick-robot]

@ammont82: once the present PR merges, I will cherry-pick it on top of releases/v2.43 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick releases/v2.43

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@ammont82: This pull request references MGMT-20897 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Related with https://issues.redhat.com/browse/MGMT-20897

Add a cluster validation for openshift-ai.

If the cluster has no GPU, a warning in the front should be displayed.
This validation appears in "Host Discovery" step.

Summary by CodeRabbit

• New Features

• Added support for GPU requirements validation in the cluster wizard.

• Improvements

• Introduced arbiter node requirements to cluster host requirements details.

• Other Changes

• Removed an outdated feature support level related to skipping MCO reboot.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ammont82, celdrake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ammont82,celdrake]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-cherrypick-robot]

@ammont82: new pull request created: #3057

Details

In response to this:

/cherry-pick releases/v2.43

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.