MGMT-20895: Use humanized label for displaying the selected subnet

[celdrake]

The currentDisplayValue in SubnetsDropdown was kept in an unnecessary useState, since it's value can be derived from other fields. On top of that, when the component first mounted, currentDisplayValue had the humanized label (eg. 192.168.122.0/24 (192.168.122.0 - 192.168.122.255)), but when the user modified the selection, the display value had only the field value (eg. 192.168.122.0/24).

Now currentDisplayValue is always displaying the humanized label, and it's calculated from the fields it derives from.

Summary by CodeRabbit

• Tests
  • Enhanced networking UI tests to verify correct display of IPv4 and IPv6 subnet CIDR ranges during single and dual-stack configurations.
• Refactor
  • Streamlined subnet dropdown label logic for more efficient and consistent display behavior.

[openshift-ci-robot]

@celdrake: This pull request references MGMT-20895 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

The currentDisplayValue in SubnetsDropdown was kept in an unnecessary useState, since it's value can be derived from other fields. On top of that, when the component first mounted, currentDisplayValue had the humanized label (eg. 192.168.122.0/24 (192.168.122.0 - 192.168.122.255)), but when the user modified the selection, the display value had only the field value (eg. 192.168.122.0/24).

Now currentDisplayValue is always displaying the humanized label, and it's calculated from the fields it derives from.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

The changes enhance networking configuration test coverage by adding assertions for IPv4 and IPv6 subnet CIDRs, introduce two new Cypress getter methods for subnet fields, and refactor the SubnetsDropdown component to use a memoized value for dropdown items and display label, simplifying state management and logic.

Changes

File(s)	Change Summary
libs/ui-lib-tests/cypress/integration/dualstack/2-networking.cy.ts	Enhanced tests to assert correct display of IPv4 and IPv6 subnet CIDRs and ranges in networking UI.
libs/ui-lib-tests/cypress/views/networkingPage.ts	Added getClusterSubnetCidrIpv4 and getClusterSubnetCidrIpv6 getter methods for subnet CIDR input fields.
libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/SubnetsDropdown.tsx	Refactored to use useMemo for dropdown items and display label; removed separate state and effect for label.

Sequence Diagram(s)

sequenceDiagram
    participant Test as Cypress Test
    participant UI as Networking UI
    participant SubnetsDropdown as SubnetsDropdown Component

    Test->>UI: Visit networking page
    Test->>UI: Assert IPv4/IPv6 subnet CIDR fields (via new getters)
    UI->>SubnetsDropdown: Render dropdown
    SubnetsDropdown->>SubnetsDropdown: Compute items and display label with useMemo
    Test->>UI: Switch to dual-stack mode
    UI->>SubnetsDropdown: Rerender with updated subnets
    SubnetsDropdown->>SubnetsDropdown: Recompute items and label
    Test->>UI: Assert updated IPv4/IPv6 subnet CIDR fields

Loading

Possibly related PRs

• openshift-assisted/assisted-installer-ui#2986: Modifies the same SubnetsDropdown component by adding id attributes to UI elements, focusing on accessibility and testability.

Suggested labels

lgtm, size/S

Suggested reviewers

• ammont82
• jgyselov

Poem

In the garden of code where subnets grow,
Rabbits test both v4 and v6 in a row.
With memoized dropdowns, the logic is neat,
New getters hop in, making tests complete.
Hooray for the network, so crisp and so clear,
The bunnies approve—let’s give a cheer! 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/SubnetsDropdown.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "@openshift-assisted/eslint-config" to extend from. Please check that the name of the config is correct.

The config "@openshift-assisted/eslint-config" was referenced from the config file in "/libs/ui-lib/.eslintrc.cjs".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19aa466 and d774dd6.

📒 Files selected for processing (3)

• libs/ui-lib-tests/cypress/integration/dualstack/2-networking.cy.ts (2 hunks)
• libs/ui-lib-tests/cypress/views/networkingPage.ts (1 hunks)
• libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/SubnetsDropdown.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

• libs/ui-lib-tests/cypress/integration/dualstack/2-networking.cy.ts
• libs/ui-lib-tests/cypress/views/networkingPage.ts
• libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/SubnetsDropdown.tsx

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: unit-tests
• GitHub Check: translation-files
• GitHub Check: tests
• GitHub Check: circular-deps
• GitHub Check: lint
• GitHub Check: format

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[celdrake]

@ammont82 @jgyselov I verified the fix works well in Single Stack + Cypress tests, but I couldn't test the changes for real in Dual Stack clusters.

Could you help me with how to configure for Dual Stack? Thanks.

[openshift-ci-robot]

@celdrake: This pull request references MGMT-20895 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

The currentDisplayValue in SubnetsDropdown was kept in an unnecessary useState, since it's value can be derived from other fields. On top of that, when the component first mounted, currentDisplayValue had the humanized label (eg. 192.168.122.0/24 (192.168.122.0 - 192.168.122.255)), but when the user modified the selection, the display value had only the field value (eg. 192.168.122.0/24).

Now currentDisplayValue is always displaying the humanized label, and it's calculated from the fields it derives from.

Summary by CodeRabbit

• Tests
• Enhanced networking UI tests to verify correct display of IPv4 and IPv6 subnet CIDR ranges during single and dual-stack configurations.
• Refactor
• Improved the logic for displaying subnet dropdown labels, resulting in more efficient and consistent UI behavior.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@celdrake: This pull request references MGMT-20895 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

The currentDisplayValue in SubnetsDropdown was kept in an unnecessary useState, since it's value can be derived from other fields. On top of that, when the component first mounted, currentDisplayValue had the humanized label (eg. 192.168.122.0/24 (192.168.122.0 - 192.168.122.255)), but when the user modified the selection, the display value had only the field value (eg. 192.168.122.0/24).

Now currentDisplayValue is always displaying the humanized label, and it's calculated from the fields it derives from.

Summary by CodeRabbit

• Tests
• Enhanced networking UI tests to verify correct display of IPv4 and IPv6 subnet CIDR ranges during single and dual-stack configurations.
• Refactor
• Streamlined subnet dropdown label logic for more efficient and consistent display behavior.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ammont82, celdrake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ammont82,celdrake]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment