Skip to content

NO-ISSUE: Button text is not an icon #3174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Sep 22, 2025
Merged

NO-ISSUE: Button text is not an icon #3174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion apps/assisted-ui/src/components/AboutButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ export const AboutButton: React.FC = () => {
const handleClick = () => setIsModalOpen(true);
return (
<>
<Button icon="About" variant={ButtonVariant.plain} onClick={handleClick} id="button-about" />
<Button variant={ButtonVariant.plain} onClick={handleClick} id="button-about">
About
</Button>
<AboutModal isOpen={isModalOpen} onClose={handleCloseAboutModal} />
</>
);
Expand Down
10 changes: 4 additions & 6 deletions apps/assisted-ui/src/components/FeedbackButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,11 @@ import { Constants } from '@openshift-assisted/ui-lib/ocm';

export const FeedbackButton: React.FC = () => (
<Button
icon={
<>
Provide feedback <ExternalLinkAltIcon />
</>
}
icon={<ExternalLinkAltIcon />}
variant={'plain'}
onClick={() => window.open(Constants.FEEDBACK_FORM_LINK, '_blank', 'noopener noreferrer')}
Comment thread
jgyselov marked this conversation as resolved.
id="button-feedback"
/>
>
Provide feedback
</Button>
);
Loading