Backport critical Discussions changes to Olive - #31345
Merged
arbrandes merged 16 commits intoDec 8, 2022
Merged
Conversation
This change documents some of the workings of the discussions app for reference.
Course topics are now created by traversing the entire course structure from top to bottom instead of starting at the sequential level and then moving up or down as needed. This also introduces a lot of debug logs to pontetially find the reason why under some circumstances new units don't get processed and end up without a discussions topic.
When running in a sharded MongoDB setup it's possible that querying the modulestore right after the course publish signal will not return the latest data. This commit adds a delay similar to the one used in other places in the codebase for a similar reason.
Co-authored-by: adeel.tajamul <adeel.tajamul@arbisoft.com>
* fix: updated topic sorting for discussions MFE * feat: updated topic sorting test case
…uctor paced courses
Co-authored-by: adeel.tajamul <adeel.tajamul@arbisoft.com>
Co-authored-by: adeel.tajamul <adeel.tajamul@arbisoft.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This was referenced Nov 25, 2022
Contributor
Author
|
Note to self: pull this one in when it lands. (As well as the MFE equivalent). |
Contributor
Author
|
Approved by @asadazam93 in Slack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because frontend-app-discussions is now a candidate for inclusion in Olive, this backports the important changes to discussions in
mastersinceolive.masterwas cut, primarily to synchronize the edx-platform clients and APIs with the corresponding cs_comments_service backport.