This repository was archived by the owner on Oct 13, 2025. It is now read-only.
Sync to master - #399
Merged
arbrandes merged 7 commits intoNov 30, 2022
Merged
Conversation
The user stats API had a few issues that were breaking pagination. First of all the total count of entries was reported as the count after limiting to the per-page limit. This meant that the count would be limited to the page count even if there were more entries. This commit adds a facet to the query that fetches the total count, and the data after limiting. Another issue was using skip after limit, which is the incorrect order. This commit fixes that.
…earner-pagination fix: pagination for user stats api [BD-38]
When using the default `user_activity` filter for the active threads API, the pagination and sorting happens in Ruby instead of MongoDB. In addition, when using the unread filter, the pagination mechanism is different. This code introduces a fix for when they are both used together.
…nread-pagination fix: pagination behaviour of user active threads API [BD-38]
…82/add_reverse_order_param [BD-38][INF-544][BB-6682] feat: implement reverse_order parameter
This was referenced Nov 25, 2022
4 tasks
xitij2000
approved these changes
Nov 30, 2022
xitij2000
left a comment
xitij2000
left a comment
Contributor
There was a problem hiding this comment.
Looks good! I think commit related to sorting can be potentially skipped since they add a feature here that won't be in use in Olive. But I don't see any harm in including them either.
Author
|
I'll leave the sorting ones in for the sake of being completely in sync with master, which might make the olive.1 and olive.2 easier. Thanks @xitij2000! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge master into the Olive branch.