Skip to content

docs: Include in Open edX release - #363

Merged
arbrandes merged 1 commit into
openedx:masterfrom
arbrandes:include-in-release
Nov 28, 2022
Merged

docs: Include in Open edX release#363
arbrandes merged 1 commit into
openedx:masterfrom
arbrandes:include-in-release

Conversation

@arbrandes

Copy link
Copy Markdown
Contributor

Commit to including the MFE in Open edX releases going forward.

@codecov

codecov Bot commented Nov 25, 2022

Copy link
Copy Markdown

Codecov Report

Base: 85.19% // Head: 85.19% // No change to project coverage 👍

Coverage data is based on head (fc95d16) compared to base (5e12d87).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head fc95d16 differs from pull request most recent head d679f1e. Consider uploading reports for the commit d679f1e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #363   +/-   ##
=======================================
  Coverage   85.19%   85.19%           
=======================================
  Files         134      134           
  Lines        2675     2675           
  Branches      737      737           
=======================================
  Hits         2279     2279           
  Misses        374      374           
  Partials       22       22           
Impacted Files Coverage Δ
src/discussions/topics/data/selectors.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@arbrandes
arbrandes force-pushed the include-in-release branch 2 times, most recently from 42ac093 to cba2963 Compare November 28, 2022 12:30
Commit to including the MFE in Open edX releases going forward.
@arbrandes

Copy link
Copy Markdown
Contributor Author

Since technically this is a minor change with no production impact and we're running out of time to include this MFE in Olive, i'm going to go ahead and merge this.

@arbrandes
arbrandes merged commit 5c3d561 into openedx:master Nov 28, 2022
@nedbat

nedbat commented Nov 28, 2022

Copy link
Copy Markdown
Contributor

fwiw, "docs:" should be changes to words that people read. This is "build:".

@arbrandes
arbrandes deleted the include-in-release branch December 7, 2022 22:24
moonesque pushed a commit to edSPIRIT/frontend-app-discussions that referenced this pull request Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants